Rename hiuvi -> Caspion #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 22, 2021
brafdlog
commented
Jun 22, 2021
| @@ -10,7 +10,7 @@ import * as googleSheets from './googleSheetsInternalAPI'; | |||
| import { appendToSpreadsheet } from './googleSheetsInternalAPI'; | |||
|
|
|||
| const GOOGLE_SHEETS_DATE_FORMAT = 'DD/MM/YYYY'; | |||
| const DEFAULT_SHEET_NAME = '_hiuvi'; | |||
| const DEFAULT_SHEET_NAME = '_caspion'; | |||
There was a problem hiding this comment.
This is a breaking change for people who are already using the integration with google sheets, but I think it is worth doing it now and not leaving this old reference in the code.
There was a problem hiding this comment.
Yes... but we will need to stop breaking the app someday 😉
baruchiro
reviewed
Jun 23, 2021
| @@ -36,7 +36,7 @@ jobs: | |||
| script: | | |||
| const releases = await github.repos.listReleases({ | |||
| owner: 'brafdlog', | |||
| repo: 'hiuvi' | |||
| repo: 'caspion' | |||
There was a problem hiding this comment.
You need to change the repo in Github
baruchiro
approved these changes
Jun 23, 2021
baruchiro
force-pushed
the
renameHiuviToCaspion
branch
from
07027bf
to
deaf541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.