Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NTP Tutorial Page #16033

Closed
anthonypkeane opened this issue May 21, 2021 · 5 comments · Fixed by brave/brave-core#9158
Closed

Implement NTP Tutorial Page #16033

anthonypkeane opened this issue May 21, 2021 · 5 comments · Fixed by brave/brave-core#9158

Comments

@anthonypkeane
Copy link

anthonypkeane commented May 21, 2021

Description:

Spec "NTP Tutorial Page"

Region: Japan only

URL: https://brave.com/ja/android-ntp-tutorial

When the users location is set to Japan, please auto load the above URL after onboarding.

@anthonypkeane
Copy link
Author

cc @soi-tnk so you can keep track of progress

@anthonypkeane
Copy link
Author

@soi-tnk please note this is scheduled for 1.28 currently

@srirambv
Copy link
Contributor

@anthonypkeane there was an uplift for this but should that be removed and left it for 1.28.x?

@anthonypkeane
Copy link
Author

1.27 is perfect too @srirambv TY

@kjozwiak
Copy link
Member

kjozwiak commented Jul 22, 2021

Verification PASSED on Samsung S10+ running Android 11 using the following build:

1.27.107 Chromium: 92.0.4515.107
  • ensured that https://brave.com/ja/android-ntp-tutorial is being opened in a NTP in the following scenarios:
    • ensured that the NTP correctly opens after Privacy Stats (which is basically the end of onboarding)
    • ensured that the NTP correctly opens if Privacy Stats is skipped
    • ensured that the NTP correctly opens when Brave is set as the default browser
  • ensured that https://brave.com/ja/android-ntp-tutorial isn't being opened in a NTP for Germany, Canada, Polish
  • ensured that https://brave.com/ja/android-ntp-tutorial matches the link mentioned via Implement NTP Tutorial Page #16033 (comment)

Verification PASSED on Samsung Galaxy Tab A running Android 10 using the following build:

1.27.107 Chromium: 92.0.4515.107
  • ensured that https://brave.com/ja/android-ntp-tutorial is being opened in a NTP in the following scenarios:
    • ensured that the NTP correctly opens after Privacy Stats (which is basically the end of onboarding)
    • ensured that the NTP correctly opens if Privacy Stats is skipped
    • ensured that the NTP correctly opens when Brave is set as the default browser
  • ensured that https://brave.com/ja/android-ntp-tutorial isn't being opened in a NTP for Germany, Canada, Polish
  • ensured that https://brave.com/ja/android-ntp-tutorial matches the link mentioned via Implement NTP Tutorial Page #16033 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants