Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ntp tutorial jp android (Uplift to 1.27.x) #9466

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Ntp tutorial jp android (Uplift to 1.27.x) #9466

merged 1 commit into from
Jul 21, 2021

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Jul 16, 2021 •
edited by kjozwiak
Loading

Uplift of #9158 & #9457
Resolves brave/brave-browser#16033 & brave/brave-browser#16949

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jul 16, 2021
@deeppandya deeppandya added this to the 1.27.x - Release milestone Jul 16, 2021
@deeppandya deeppandya requested a review from a team July 16, 2021 17:04
@deeppandya deeppandya self-assigned this Jul 16, 2021
@deeppandya deeppandya mentioned this pull request Jul 16, 2021
Closed
7 tasks
@deeppandya deeppandya force-pushed the ntp_tutorial_jp_android_2_1.27.x branch from 768d574 to d673236 Compare July 21, 2021 15:00
kjozwiak
kjozwiak approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.27.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #9457 (comment).

@kjozwiak kjozwiak merged commit b483491 into 1.27.x Jul 21, 2021
@kjozwiak kjozwiak deleted the ntp_tutorial_jp_android_2_1.27.x branch July 21, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@deeppandya deeppandya

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.27.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@deeppandya @kjozwiak