Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ntp tutorial jp android (Uplift to 1.27.x) #9434

Closed
wants to merge 1 commit into from
Closed

Ntp tutorial jp android (Uplift to 1.27.x) #9434

wants to merge 1 commit into from

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Jul 14, 2021 •
edited
Loading

Uplift of #9158
Resolves brave/brave-browser#16033

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jul 14, 2021
@deeppandya deeppandya added this to the 1.27.x - Beta milestone Jul 14, 2021
@deeppandya deeppandya requested a review from a team July 14, 2021 15:50
@deeppandya deeppandya self-assigned this Jul 14, 2021
@srirambv
Copy link
Contributor

@deeppandya Could you correct the uplift PR? Its linked to a different one

@deeppandya
Copy link
Contributor Author

@deeppandya Could you correct the uplift PR? Its linked to a different one

Sorry my bad. updated the PR.

@LaurenWags
Copy link
Member

Labelling PR/Blocked after discussion with @srirambv

@deeppandya
Copy link
Contributor Author

@LaurenWags @srirambv the PR is ready for the change but CI keeps on failing so trying one last time before reacjing out to devops. #9457

@deeppandya
Copy link
Contributor Author

@LaurenWags @srirambv created another uplift PR : #9466. can i close this PR ?

@LaurenWags
Copy link
Member

@deeppandya sure, if this one is no longer valid please do close 👍🏻

@deeppandya
Copy link
Contributor Author

Closing this PR as it's irrelevant

@deeppandya deeppandya closed this Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@deeppandya deeppandya

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 Uplift/Blocked
Projects
None yet
Milestone
1.27.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@deeppandya @srirambv @LaurenWags