Add IPFS buttons to protocol badge popup #9899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bbondy @karenkliu any propositions about icons/texts maybe? |
spylogsster
force-pushed
the
issue-16907
branch
2 times, most recently
from
7721fa5 to
239b711
Compare
|
Nice to have request: Add visual distinction for things that are clickable vs not. Eg, underline links, or make them buttons. Or sometimes I see the icon at the end of the line which is like an arrow, signifying that you click that in order to leave native UI to open a link. |
|
I defer to @karenkliu but if not you can always start with just links |
bbondy
approved these changes
Aug 30, 2021
mkarolin
reviewed
Aug 30, 2021
Comment on lines
6
to
16
| #include "brave/common/webui_url_constants.h" | ||
| #include "brave/components/vector_icons/vector_icons.h" | ||
| #include "brave/components/ipfs/ipfs_constants.h" | ||
| #include "brave/components/ipfs/ipfs_utils.h" | ||
| #include "brave/grit/brave_theme_resources.h" | ||
| #include "chrome/browser/ui/views/page_info/page_info_bubble_view.h" | ||
| #include "chrome/browser/ui/views/page_info/page_info_view_factory.h" | ||
| #include "components/grit/brave_components_strings.h" | ||
| #include "chrome/browser/ui/browser_tabstrip.h" | ||
| #include "chrome/browser/ui/browser_finder.h" | ||
| #include "ui/base/l10n/l10n_util.h" |
There was a problem hiding this comment.
Please, make sure the target already has deps for all these.
mkarolin
approved these changes
Aug 30, 2021
spylogsster
force-pushed
the
issue-16907
branch
from
253ef8d to
958ed5b
Compare
|
LGTM! :) |
spylogsster
force-pushed
the
issue-16907
branch
from
958ed5b to
3cd79c5
Compare
lidel
approved these changes
Aug 30, 2021
spylogsster
force-pushed
the
issue-16907
branch
2 times, most recently
from
0cecc27 to
d58bdfd
Compare
spylogsster
force-pushed
the
issue-16907
branch
2 times, most recently
from
9025860 to
7075432
Compare
spylogsster
force-pushed
the
issue-16907
branch
from
7075432 to
a79c514
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#16907
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: