-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fingerprinting v3: Accept-Language #20096
Comments
@fmarier pointed out that this is likely not a great idea, and that there are cases where the variants are useful. So, more planning is needed for the default protections category. Possibilities include:
Im going to brain some more on this, see what other browsers are doing, and revise the default protection approach. But farbling the weight, and reporting a fixed value in the max protection category seem like good options never the less 🤞 |
For reference, here's how my laptop is set:
and that ends up with the following odd request header:
|
Additional data:
Safari doing so makes me think this is likely to have acceptable WebComapt implications. We could also create a flag or system preference for this (and possibly align it with font fingerprinting protections) so that users have a global escape valve if needed |
I'm guessing the plan is for it to be opt-out via a setting in brave://settings? |
yep yep! |
Fixes brave/brave-browser#23093 Unfixes brave/brave-browser#20096 Unfixes brave/brave-browser#816 Reverts #13807 Which fixed brave/brave-browser#23489 Reverts #13205 Which fixed brave/brave-browser#22605 Reverts #12234 Which fixed brave/brave-browser#20096 and brave/brave-browser#816
Fixes brave/brave-browser#23093 Unfixes brave/brave-browser#20096 Unfixes brave/brave-browser#816 Reverts #13807 Which fixed brave/brave-browser#23489 Reverts #13205 Which fixed brave/brave-browser#22605 Reverts #12234 Which fixed brave/brave-browser#20096 and brave/brave-browser#816
This is a sub-issue of the larger fingerprint defense reorganization issue: #11770
Currently Brave (like most browsers) will in some configurations report fine-grained information about language preferences in the request Accept-Language header.
For example, setting the system language preference to "French (Switzerland)" sends
Accept-Language: fr-FR,fr;q=0.9
; setting it to "French (Canadian)" sendsAccept-Language: fr-CA,fr;q=0.9
. Thefr-<WHATEVER>
bit ends up being a useful distinguishing bit for fingerprinters.This issue is to address this fingerprinting concern as follows:
default protection:
fr;q=0.9
(we'd dropfr-FR
andfr-CA
). Do not drop alphabet variants though (e.g.,sr-Latn
).q
), farble it and report a randomly determined value between 0.5 and 0.9.max protection:
Accept-Language: en-US,en;q=X.X
The text was updated successfully, but these errors were encountered: