Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields breaking fonts on Feedly #23489

Closed
pilgrim-brave opened this issue Jun 15, 2022 · 5 comments · Fixed by brave/brave-core#13807
Closed

Shields breaking fonts on Feedly #23489

pilgrim-brave opened this issue Jun 15, 2022 · 5 comments · Fixed by brave/brave-core#13807

Comments

@pilgrim-brave
Copy link

spun off from #23093 (comment) because this bug has a separate root cause and was not fixed when other sites mentioned in that issue were fixed

@stephendonner
Copy link

stephendonner commented Jun 16, 2022

Testplan:

  1. install latest Brave
  2. launch Brave
  3. load feedly.com
  4. click on the Login button
  5. look at the text, comparing to below:
actual expected
171302118-46f384bb-dc91-492f-b98e-bcfd1b2008b6 171302132-5ba1b818-55f5-4f95-a5cd-1e6251710ab7

@kjozwiak kjozwiak removed the OS/Android Fixes related to Android browser functionality label Jun 17, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Jun 17, 2022

Removing the OS/Android label as it looks like Android wasn't affected, specifically the STR/Case @stephendonner mentioned above. Example using 1.39.120 Chromium: 102.0.5005.99 which doesn't include the fix from brave/brave-core#13807 but has Font FP which was introduced in 1.39.x:

Shields Enabled with default FP Shields Disabled
Screenshot_20220616-221923_Brave Screenshot_20220616-221930_Brave

Doesn't seem to affect Linux either. Used 1.39.122 Chromium: 102.0.5005.115 which doesn't have the above fix but looks like everything is working as expected. Example:

Shields Enabled with default FP Shields Disabled
image image

@kjozwiak kjozwiak added feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/macOS release-notes/include and removed release-notes/exclude labels Jun 17, 2022
@kjozwiak
Copy link
Member

Looks like this might have regressed Win as it was working using 1.39.122 Chromium: 102.0.5005.115 but now seems to have regressed while using 1.42.2 Chromium: 103.0.5060.53. Example:

Using 1.39.122 Chromium: 102.0.5005.115

Shields Enabled (FP using default) Shields Disabled
image image

Using 1.42.2 Chromium: 103.0.5060.53

Shields Enabled (FP using default) Shields Disabled
image image

@kjozwiak
Copy link
Member

kjozwiak commented Jun 17, 2022

@brave/qa-team Win case will be handled via #23541. The above requires 1.40.104 or higher for 1.40.x verification 👍

@stephendonner
Copy link

Verified PASSED using

Brave 1.40.104 Chromium: 103.0.5060.53 (Official Build) (x86_64)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS macOS Version 11.6.7 (Build 20G630)

Tested several times (with and without app restarts), with both new and pre-existing profiles.

Couldn't get it to fail 👍

run 1 run 5 run 8 run 17
Screen Shot 2022-06-18 at 6 27 06 PM Screen Shot 2022-06-18 at 6 28 06 PM Screen Shot 2022-06-18 at 6 29 45 PM Screen Shot 2022-06-18 at 6 30 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment