Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option Enable Tab Group auto creation #22105

Closed
samartnik opened this issue Apr 5, 2022 · 3 comments · Fixed by brave/brave-core#12907
Closed

Add an option Enable Tab Group auto creation #22105

samartnik opened this issue Apr 5, 2022 · 3 comments · Fixed by brave/brave-core#12907
Assignees
@samartnik
Labels
feature/new-tab OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.37.x - Release #6

Comments

@samartnik
Copy link
Contributor

samartnik commented Apr 5, 2022 •
edited by kjozwiak
Loading

Description

Add an option Enable Tab Group auto creation to Appearance section. This option is hidden in Chromium currently and the task is to make it available for users to choose preferable behaviour.
Note: this option also controls Open in new tab context menu #15120

Additional discussion for this option here https://bravesoftware.slack.com/archives/C0816QH3R/p1648918830112949

Steps to reproduce

  1. Open any article on https://cnn.com.
  2. Select any word and click Web search.
  3. New tab is opened outside of Tab Groups.

Several other cases outlined via brave/brave-core#12907 (comment).

Actual result

New tab is always opened outside of Tab Groups.

Expected result

New tab is opened in Tab Groups by default, but can it be controlled by new option.

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information
@samartnik samartnik added the OS/Android Fixes related to Android browser functionality label Apr 5, 2022
@samartnik samartnik self-assigned this Apr 5, 2022
@samartnik samartnik mentioned this issue Apr 6, 2022
Merged
25 tasks
@samartnik samartnik added this to the 1.39.x - Nightly milestone Apr 6, 2022
This was referenced Apr 6, 2022
Merged
Merged
@kjozwiak
Copy link
Member

Above requires 1.37.114 or higher for 1.37.x verification.

@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 13, 2022 •
edited
Loading

Verified using version 1.37.114, Chromium 100.0.4896.88 on Samsung Galaxy S21 running Android 12

  • Verified Enable Tab Group auto creation option in Appearance setting
  • Using web search from context menu will open tab in group when enabled
  • Ensured user is able to open multiple tabs in group
  • Ensured user is able to remove tabs in group/Close all tabs
  • Verified Tab group is not created with web search when option disabled
  • Toggling Enable Tab Group auto creation option prompts brave app to relaunch

Upgrade: (1.37.112 -> 1.37.114)

  • Ensured Enable Tab group auto creation is toggled on when upgrading
  • User is able to disable Enable Tab group auto creation
  • User is able to group open tabs post upgrade using the web search context menu
  • Ensured Tab groups are not reset upon upgrading (known issue) - Tab groups are reset after app upgrade #21248
1 2 3 4
Screen Shot 2022-04-13 at 4 23 54 PM Screen Shot 2022-04-13 at 4 24 08 PM Screen Shot 2022-04-13 at 4 26 20 PM Screen Shot 2022-04-13 at 4 26 52 PM

@kjozwiak kjozwiak mentioned this issue Apr 15, 2022
Closed
avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
Brave Browser 1.37.116
9080753 
 - Improved general performance by fixing cosmetic filters. ([#22030](brave/brave-browser#22030))
 - Added "Enable Tab Group auto creation" setting under "Appearance" which controls the ability to open links in separate tabs. ([#22105](brave/brave-browser#22105))
 - Fixed rounding issues under Brave Wallet via the "Send" and "Swap" panels by increasing the digits after the decimal to 0.00000000 (8 digits) from 0.000000 (6 digits). ([#22257](brave/brave-browser#22257))
 - Fixed crash when attempting to send opened tab to another devices on sync chain using "Send to your devices". ([#22128](brave/brave-browser#22128))
 - Upgraded Chromium to 100.0.4896.127. ([#22318](brave/brave-browser#22318)) ([Changelog for 100.0.4896.127](https://chromium.googlesource.com/chromium/src/+log/100.0.4896.88..100.0.4896.127?pretty=fuller&n=1000))
@xVemu
Copy link

xVemu commented Jul 30, 2023

Is it possible to activate on pc version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
feature/new-tab OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Milestone
1.37.x - Release #6
Development

Successfully merging a pull request may close this issue.

[Android] Added option Enable Tab Group auto creation brave/brave-core
5 participants
@kjozwiak @bsclifton @Uni-verse @samartnik @xVemu