Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android enable tab groups option (uplift to 1.38.x) #12918

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Android enable tab groups option (uplift to 1.38.x) #12918

merged 2 commits into from
Apr 12, 2022

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Apr 6, 2022 •
edited by kjozwiak
Loading

Uplift of #12907
Fixes brave/brave-browser#22105

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 6, 2022
@samartnik samartnik added this to the 1.38.x - Beta milestone Apr 6, 2022
@samartnik samartnik requested a review from a team April 6, 2022 19:09
@bsclifton bsclifton changed the title Android enable tab groups option 1.38.x Android enable tab groups option (uplift to 1.38.x) Apr 6, 2022
kjozwiak
kjozwiak approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.38.x approved 👍 QA has verified the PR on Nightly as per #12907 (comment).

@kjozwiak kjozwiak merged commit 4fb2bf8 into 1.38.x Apr 12, 2022
@kjozwiak kjozwiak deleted the android_enable_tab_groups_option_1.38.x branch April 12, 2022 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@samartnik samartnik

@brave-builds brave-builds

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@samartnik @kjozwiak @brave-builds