Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Added option Enable Tab Group auto creation #12907

Merged
merged 2 commits into from
Apr 6, 2022

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Apr 6, 2022

Resolves brave/brave-browser#22105

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 6, 2022
@samartnik samartnik added this to the 1.39.x - Nightly milestone Apr 6, 2022
@samartnik samartnik self-assigned this Apr 6, 2022
Copy link

@Pavneet-Sing Pavneet-Sing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

CachedFeatureFlags.resetFlagsForTesting();
}
}

public static boolean isBraveTabGroupsEnabled() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I guess it would be better if we use present context here, i.e. isBraveTabGroupsEnable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is present tense, just in passive form. It gets in line with Chromium's naming like isMultiProcessEnabled, isCaptureEnabled etc.

@samartnik samartnik merged commit e9aceea into master Apr 6, 2022
@samartnik samartnik deleted the android_enable_tab_groups_option branch April 6, 2022 17:40
@samartnik samartnik restored the android_enable_tab_groups_option branch April 6, 2022 19:05
@samartnik samartnik deleted the android_enable_tab_groups_option branch April 6, 2022 19:12
@kjozwiak
Copy link
Member

kjozwiak commented Apr 10, 2022

Verification PASSED on Pixel 6 running Android 12 using the following build(s):

1.39.42 Chromium: 100.0.4896.79

Test Case #1 - Enable Tab Group auto creation (Enabled/Default - Clean Install)

  • verified the STR/Case outlined via Add an option Enable Tab Group auto creation brave-browser#22105 (comment)
  • ensured that Enable Tab Group auto creation under Appearance is enabled by default on a clean install
  • ensured that the Enable Tab Group auto creation setting is maintained when restarting the browser
  • ensured that Open in new tab isn't visible under the context menu on tiles via the NTP
  • ensured that Open in new tab isn't visible under the context menu when tapping on hyperlinks/images
  • ensured that Open in new tab in group is working as expected via the various context menus
  • ensured that Open in Private tab is working as expected

Example of the new setting:

Screenshot_20220410-012142

Test Case #2 - Enable Tab Group auto creation (Disabled- Clean Install)

  • ensured that disabling Enable Tab Group auto creation under Appearance asks the user to restart the browser
  • ensured that disabling Enable Tab Group auto creation didn't cause any issues/visible issues
  • ensured that using Web search opens the link/content in a new tab rather than a group tab
  • ensured that tapping on Later and not restarting after disabling Enable Tab Group auto creation didn't cause issues
  • ensured that Open in new tab is being added into the various context menu's
  • ensured that Open in new tab works as expected when tapping on tiles via NTP
  • ensured that Open in new tab works as expected when tapping hyperlinks/images
  • ensured that Open in Private tab is working as expected

Test Case #3 - Enable Tab Group auto creation (Enabled - Upgrade)

  • upgraded from 1.39.36 Chromium: 100.0.4896.79 --> 1.39.47 Chromium: 100.0.4896.79
  • ensured that Enable Tab Group auto creation under Appearance is enabled
  • ensured that the Enable Tab Group auto creation setting is maintained when restarting the browser
  • ensured that Open in new tab isn't visible under the context menu on tiles via the NTP
  • ensured that Open in new tab isn't visible under the context menu when tapping on hyperlinks/images
  • ensured that Open in new tab in group is working as expected via the various context menus
  • ensured that Open in Private tab is working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option Enable Tab Group auto creation
3 participants