For media publishers, (youtube, twitch), sometimes publisher panel will switch back to site name rather than publisher name

[jasonrsadler]

Description

When opening panel on twitch or youtube publisher video, panel will switch back to youtube.com or twitch.tv instead of publisher.

Intermittent if panel is opened before page finishes loading.

Steps to Reproduce

STR from @LaurenWags originally added under #3043 (comment):

1. Clean install of 0.60.19
2. Enable Rewards
3. Navigate to youtube.com
4. Click on a video (I experienced this on every video I tried)
5. Once video starts playing click on BAT icon - it says creator info
6. Click elsewhere, panel closes.
7. Repeat steps 5 and 6 a few times and when you open the panel on the 3rd or so try, you'll see the creator info change to youtube.com. Doesn't matter if the creator is verified or not.

[LaurenWags]

I can reproduce this really easily on 0.60.19. Steps:

1. Clean install of 0.60.19
2. Enable Rewards
3. Navigate to youtube.com
4. Click on a video (I experienced this on every video I tried)
5. Once video starts playing click on BAT icon - it says creator info
6. Click elsewhere, panel closes.
7. Repeat steps 5 and 6 a few times and when you open the panel on the 3rd or so try, you'll see the creator info change to youtube.com. Doesn't matter if the creator is verified or not.

Brave	0.60.19 Chromium: 72.0.3626.81 (Official Build) beta(64-bit)
Revision	ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS	Mac OS X

[LaurenWags]

Same steps from #3043 (comment) on released version 0.59.35 do not produce this issue.

[kjozwiak]

Reproduced using @LaurenWags STR on Win 10 x64 using the following build:

Brave	0.60.19 Chromium: 72.0.3626.81 (Official Build) beta(64-bit)
Revision	ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS	Windows

Example:

Added the STR that @LaurenWags mentioned into the original comment.

[kjozwiak]

@rebron @bbondy QA believes this should be uplifted into 0.60.x when fixed. Fixing this will make tipping more reliable. It's pretty bad as you'll eventually see "YouTube" listed instead of the actual publisher.

[NejcZdovc]

@kjozwiak @LaurenWags can you reproduce this one on the latest 0.61?

[NejcZdovc]

I found one case (you need old profile), but can't reproduce it with a clean profile on the latest master

[NejcZdovc]

created new issue for the case that I found #3244

[LaurenWags]

@NejcZdovc i could not reproduce this issue on

Brave	0.61.7 Chromium: 72.0.3626.81 (Official Build) dev (64-bit)
Revision	ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS	Mac OS X

[NejcZdovc]

@LaurenWags that was my fear. I think a lot was fixed with this one brave/brave-core#1457 which is publisher update refactor. cc @kjozwiak @rebron for what to do?

[kjozwiak]

As discussed during our weekly BR/Ads meeting, @NejcZdovc is going to see if it's possible to resolve this issue with an alternative fix rather than pulling in brave/brave-core#1457 which is a large change. If the alternative fix doesn't work, we'll need to have a discussion about potentially uplifting brave/brave-core#1457 or leaving the issue in 0.60.x and getting this fixed in 0.61.x. However, this is pretty bad and we should have this fixed in 0.60.x. CCing @rebron @bbondy

[NejcZdovc]

setting milestone to 0.61 as it looks like it was fixed in that milestone

[btlechowski]

Verification passed on

Brave	0.60.40 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision	fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS	Windows 7

Used STR from the description.
youtube works great. The publisher name is always updated, even when autoplay opens a video from other publisher.
twitch also works much better, but there is still an issue., Logged: #3417

Verified passed with

Brave	0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision	fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS	Mac OS X

• Verified STR from description
• Verified for YT and Twitch, I did encounter twitch.tv instead of publisher name is shown on Brave Panel #3417 while testing

Verification passed on

Brave	0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision	fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS	Linux

Used STR from the description.