Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hackerone] browser crash #32425

Closed
diracdeltas opened this issue Aug 21, 2023 · 6 comments · Fixed by brave/brave-core#19806
Closed

[hackerone] browser crash #32425

diracdeltas opened this issue Aug 21, 2023 · 6 comments · Fixed by brave/brave-core#19806
Assignees
@simonhong
Labels
crash OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include security
Milestone
1.57.x - Release #4

Comments

@diracdeltas
Copy link
Member

reported at https://hackerone.com/reports/2117571 by 0xc4gr1

for STR see https://bravesoftware.slack.com/archives/C7VLGSR55/p1692649076620009?thread_ts=1692642768.785349&cid=C7VLGSR55
@diracdeltas diracdeltas added security priority/P2 A bad problem. We might uplift this to the next planned release. OS/Desktop labels Aug 21, 2023
@simonhong simonhong self-assigned this Aug 22, 2023
@simonhong simonhong mentioned this issue Aug 22, 2023
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Aug 22, 2023
@simonhong
Check url's scheme before binding with WebUI
b9c4953 
fix brave/brave-browser#32425
@brave-builds brave-builds added this to the 1.59.x - Nightly milestone Aug 22, 2023
This was referenced Aug 22, 2023
Merged
Merged
This was referenced Aug 22, 2023
Closed
Merged
@kjozwiak
Copy link
Member

@brave/qa-team please use https://github.com/brave/internal/issues/1064 for verification notes 👍

@kjozwiak
Copy link
Member

The above requires 1.57.53 or higher for 1.57.x verification 👍

@LaurenWags
Copy link
Member

LaurenWags commented Aug 23, 2023 •
edited
Loading

Verified with

Brave | 1.57.53 Chromium: 116.0.5845.114 (Official Build) (x86_64)
-- | --
Revision | b7a154dc9e27b02528cb2cfc8010d8edf1e35571
OS | macOS Version 13.5 (Build 22G74)

See verification notes under https://github.com/brave/internal/issues/1064#issuecomment-1689802358

@btlechowski
Copy link

Verified with

Brave 1.57.53 Chromium: 116.0.5845.114 (Official Build) (64-bit)
Revision b7a154dc9e27b02528cb2cfc8010d8edf1e35571
OS Ubuntu 18.04 LTS

See verification notes under https://github.com/brave/internal/issues/1064#issuecomment-1690119222

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.57.53 Chromium: 116.0.5845.114 (Official Build) (64-bit)
-- | --
Revision | b7a154dc9e27b02528cb2cfc8010d8edf1e35571
OS | Windows 11 Version 22H2 (Build 22621.2134)

See verification notes under https://github.com/brave/internal/issues/1064#issuecomment-1689802358

@LaurenWags
Copy link
Member

Updated to release-notes/include per discussion via https://bravesoftware.slack.com/archives/C7VLGSR55/p1692807268555479?thread_ts=1692642768.785349&cid=C7VLGSR55

@LaurenWags LaurenWags mentioned this issue Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
crash OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include security
Projects
None yet
Milestone
1.57.x - Release #4
Development

Successfully merging a pull request may close this issue.

Check url's scheme before binding with WebUI brave/brave-core
7 participants
@diracdeltas @kjozwiak @simonhong @LaurenWags @btlechowski @brave-builds @MadhaviSeelam