Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check url's scheme before binding with WebUI (uplift to 1.58.x) #19810

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Check url's scheme before binding with WebUI (uplift to 1.58.x) #19810

merged 2 commits into from
Aug 23, 2023

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 22, 2023 •
edited by kjozwiak
Loading

Uplift of #19806
Uplift of #19820
fix brave/brave-browser#32425
Fix brave/brave-browser#32449

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner August 22, 2023 17:03
@brave-builds brave-builds self-assigned this Aug 22, 2023
@brave-builds brave-builds added this to the 1.58.x - Beta milestone Aug 22, 2023
@bsclifton
Merge pull request #19820 from brave/bsc-crash-follow-up
fea89df 
Further restrict the schema for WebUI factory and redirect
kjozwiak
kjozwiak approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.58.x approved 👍 QA has verified the PR on Nightly as per https://github.com/brave/internal/issues/1064#issuecomment-1689280347.

@kjozwiak kjozwiak merged commit d02e11a into 1.58.x Aug 23, 2023
3 checks passed
@kjozwiak kjozwiak deleted the pr19806_webui_url_check_1.58.x branch August 23, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.58.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @bsclifton