Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further restrict the schema for WebUI factory and redirect #19820

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Aug 22, 2023

Fixes brave/brave-browser#32449

Contains follow up feedback for brave/brave-browser#32425

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Fixes brave/brave-browser#32449
Contains follow up feedback for https://girave-browser/issthub.com/brave/bues/32425
@bsclifton bsclifton self-assigned this Aug 22, 2023
@bsclifton bsclifton merged commit ddf2739 into master Aug 22, 2023
8 checks passed
@bsclifton bsclifton deleted the bsc-crash-follow-up branch August 22, 2023 23:58
@github-actions github-actions bot added this to the 1.59.x - Nightly milestone Aug 22, 2023
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 👍🏼

bsclifton added a commit that referenced this pull request Aug 23, 2023
Further restrict the schema for WebUI factory and redirect
bsclifton added a commit that referenced this pull request Aug 23, 2023
Further restrict the schema for WebUI factory and redirect
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.59.40 Chromium: 116.0.5845.96 (Official Build) nightly (64-bit)
-- | --
Revision | 282a4599cb1dedb4c3f8788bd21a3bf228b55d62
OS | Windows 11 Version 22H2 (Build 22621.2134)

Verification notes can be found via https://github.com/brave/internal/issues/1064#issuecomment-1689280347.

kjozwiak pushed a commit that referenced this pull request Aug 23, 2023
* Uplift of #19806 (squashed) to beta

* Merge pull request #19820 from brave/bsc-crash-follow-up

Further restrict the schema for WebUI factory and redirect

---------

Co-authored-by: Brian Clifton <brian@clifton.me>
kjozwiak pushed a commit that referenced this pull request Aug 23, 2023
* Uplift of #19806 (squashed) to release

* Merge pull request #19820 from brave/bsc-crash-follow-up

Further restrict the schema for WebUI factory and redirect

---------

Co-authored-by: Brian Clifton <brian@clifton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[hackerone] browser crash 2
4 participants