Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Disable vpn support for not subscribed users #34724

Closed
deeppandya opened this issue Dec 5, 2023 · 2 comments · Fixed by brave/brave-core#21258
Closed

[Android] Disable vpn support for not subscribed users #34724

deeppandya opened this issue Dec 5, 2023 · 2 comments · Fixed by brave/brave-core#21258
Assignees
@deeppandya
Labels
feature/vpn OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.61.x - Release

Comments

@deeppandya
Copy link

We need to disable Contact Technical Support option in Settings -> Brave Firewall + VPN if user is not subscribed the the vpn subscription.

**Test Plan : **

  1. Install fresh profile
  2. Go to Settings -> Brave Firewall + VPN
  3. Notice Contact Technical Support option if it's in disabled state.
  4. Buy a subscription
  5. Go to Settings -> Brave Firewall + VPN
  6. Contact Technical Support should be enabled.
@deeppandya deeppandya added priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality feature/vpn labels Dec 5, 2023
@deeppandya deeppandya self-assigned this Dec 5, 2023
This was referenced Dec 5, 2023
Merged
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Dec 6, 2023

The above requires 1.61.98 or higher for 1.61.x verification 👍

@hffvld
Copy link
Contributor

hffvld commented Dec 6, 2023

Verified on Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Galaxy Tab S8 / gts8wifixx-user 13 TP1A.220624.014 release-keys
- Pixel 7 / panther_beta-user 14 AP11.231020.013.A1 release-keys
Brave build: 1.61.100
Chromium: 120.0.6099.62 (Official Build) (64-bit)

STEPS:

  1. Followed the steps from [Android] Disable vpn support for not subscribed users #34724 (comment)

ACTUAL RESULTS:

  • Verified that Contact Technical Support is disabled (grayed out) if no VPN subscription is purchased
  • Verified that Contact Technical Support is enabled if a VPN subscription is purchased
  • Verified that Contact Technical Support is enabled when a VPN subscription is purchased and the VPN is ON or OFF
  • Verified that after canceling the VPN subscription, and after it expired, Contact Technical Support is grayed out again
Galaxy Tab S8
No Subscription Subscription and VPN is ON Subscription and VPN is OFF Contact Technical Support
1 2 3 4
Pixel 7
No Subscription Subscription and VPN is ON Subscription and VPN is OFF Contact Technical Support
1 2 3 4

@kjozwiak kjozwiak mentioned this issue Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/vpn OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.61.x - Release
Development

Successfully merging a pull request may close this issue.

Disable contact Technical support option if user is not subscribed brave/brave-core
4 participants
@kjozwiak @deeppandya @brave-builds @hffvld