Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable contact Technical support option if user is not subscribed #21258

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Dec 5, 2023

Resolves brave/brave-browser#34724

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Dec 5, 2023
@deeppandya deeppandya added this to the 1.63.x - Nightly milestone Dec 5, 2023
@deeppandya deeppandya self-assigned this Dec 5, 2023
@deeppandya deeppandya marked this pull request as ready for review December 5, 2023 23:50
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deeppandya deeppandya merged commit 5f0b380 into master Dec 6, 2023
18 checks passed
@deeppandya deeppandya deleted the vpn_support_resolve_android branch December 6, 2023 02:36
@kjozwiak
Copy link
Member

kjozwiak commented Dec 6, 2023

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.63.19 Chromium: 120.0.6099.56 (Official Build) canary (64-bit)
--- | ---
Revision | bb1f3ae0d0bb6f1c0b7b4457d20373c910600cd1
OS | Android 14; Build/AP11.231020.016.A1; 34; REL

Using the STR/Cases outlined via brave/brave-browser#34724 (comment), ensured that Contact Technical Support is disabled if a user doesn't have an active subscription enabled. Also ensured that Contact Technical Support becomes active/usable once a subscription has been purchased as per the following:

Example Example Example Example Example Example Example Example
Screenshot_20231206-020149 Screenshot_20231206-020159 Screenshot_20231206-020202 Screenshot_20231206-020205 Screenshot_20231206-020211 Screenshot_20231206-020217 Screenshot_20231206-020226 Screenshot_20231206-020237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Disable vpn support for not subscribed users
3 participants