Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable contact Technical support option if user is not subscribed [Uplift to 1.62.x] #21259

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Disable contact Technical support option if user is not subscribed [Uplift to 1.62.x] #21259

merged 2 commits into from
Dec 6, 2023

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Dec 5, 2023 •
edited by kjozwiak
Loading

Uplift of #21258
Resolves brave/brave-browser#34724

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Dec 5, 2023
@deeppandya deeppandya added this to the 1.62.x - Beta milestone Dec 5, 2023
@deeppandya deeppandya self-assigned this Dec 5, 2023
@deeppandya deeppandya marked this pull request as ready for review December 5, 2023 23:54
@deeppandya deeppandya requested a review from a team as a code owner December 5, 2023 23:54
kjozwiak
kjozwiak approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.62.x approved 👍 QA has verified the PR on Nightly via 1.63.x as per #21258 (comment).

@kjozwiak kjozwiak merged commit 53d918e into 1.62.x Dec 6, 2023
14 checks passed
@kjozwiak kjozwiak deleted the vpn_support_resolve_android_1.62.x branch December 6, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@deeppandya deeppandya

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.62.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@deeppandya @kjozwiak