Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds error logic for one-time tip #1488

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Adds error logic for one-time tip #1488

merged 1 commit into from
Feb 4, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 29, 2019

Resolves brave/brave-browser#3052

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • enable rewards
  • claim grant
  • go to verified site
  • open panel
  • select amount in donation banner
  • (when you will click send tip you need to turn internet off immediately)
  • click send tip
  • disable internet
  • make sure that you see error in the panel
    untitled

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@davidtemkin
Copy link

@NejcZdovc please change text to "Unable to sent your tip. Please try again later."

@NejcZdovc
Copy link
Contributor Author

@davidtemkin done

Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ thanks for change

@NejcZdovc NejcZdovc merged commit 8d4fbdd into master Feb 4, 2019
@NejcZdovc NejcZdovc deleted the tip-retry branch February 4, 2019 06:27
NejcZdovc added a commit that referenced this pull request Feb 4, 2019
Adds error logic for one-time tip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change retry and error logic for one-time tips
3 participants