Adds error logic for one-time tip #1639
Conversation
| @@ -214,7 +214,7 @@ | |||
| "description": "We show this string in the notification when you don't have enough funds for contribution" | |||
| }, | |||
| "contributeNotificationTipError": { | |||
| "message": "There was a problem processing your tip, please try again.", | |||
| "message": "Unable to send your tip. Please try again later.", | |||
There was a problem hiding this comment.
We can skip this change in 0.60, so that we don't trigger new translations
There was a problem hiding this comment.
yup, that sounds good! @NejcZdovc mind removing the strings moving that change into 0.61.x instead? This way we can get this uplifted into 0.60.x and the string changes can go into 0.61.x. @rebron agreed that we can punt on the string changes.
There was a problem hiding this comment.
Uplift to 0.60.x approved after deliberating with @rebron and @bsclifton. Lets remove the string changes from this PR so we don't need to order new translations and move it onto 0.61.x. This way we can still get the fix into 0.60.x and the string changes can go into 0.61.x. Please make sure we create a new issue for the string changes and move all associated issue(s) into the correct milestones.
Adds error logic for one-time tip
NejcZdovc
force-pushed
the
tip-retry-60
branch
from
495a289
to
18c14f1
Compare
|
@kjozwiak we don't need new issue as new string is already in 0.61 |
|
Awesome, thanks @NejcZdovc 👍 |
Original PR: #1488
Resolves brave/brave-browser#3052