Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change retry and error logic for one-time tips #3052

Closed
davidtemkin opened this issue Jan 22, 2019 · 5 comments · Fixed by brave/brave-core#1488
Closed

Change retry and error logic for one-time tips #3052

davidtemkin opened this issue Jan 22, 2019 · 5 comments · Fixed by brave/brave-core#1488
Assignees
Labels

Comments

@davidtemkin
Copy link

If Phase 1 of the contribution process fails on initial attempt, change the logic so that:

-- We do not retry
-- We send a Rewards notification with the message: "Unable to send tip. Please try again later."

If Phase 1 succeeds, we show the tip in the tips panel and reflect it in the Rewards summary.

If there is an error while attempting to complete Phase 2 of the contribution process (in which the votes are being sent) the normal retry logic applies.

@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 22, 2019
@NejcZdovc NejcZdovc added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 22, 2019
@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned kjozwiak Jan 22, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 29, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 31, 2019
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.61.x - Dev Feb 4, 2019
@NejcZdovc NejcZdovc removed this from the 0.61.x - Dev milestone Feb 12, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Feb 14, 2019

I am encountering #2297 when I try the test plan from brave/brave-core#1488. I waited a few minutes with internet off (no notification showed on BAT logo) and when I turned my internet back on, my tip went thru.

@LaurenWags
Copy link
Member

Tried again, this time I got the notification, but when I turned my internet back on, my balance had still gone down by the amount of the tip even though no tip was recorded. Still seems like I'm encountering #2297.

@GeetaSarvadnya
Copy link

While testing brave/brave-core#1488 on Windows, I am not getting any notification showed on BAT logo, when internet is OFF. Also when internet back ON I am encountering #2297

@LaurenWags
Copy link
Member

LaurenWags commented Feb 15, 2019

Tried again with

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

This time, after disabling internet and waiting about 1-1.5 minutes, no notification showed on BAT logo that tip could not go thru and again, 1 BAT (tip amount) was deducted from my wallet but no Tip displayed on tips list or in summary. After waiting a few more minutes, tip showed up in tips panel and on summary. @NejcZdovc how long should I leave the internet off for to verify that I'll get a message about tip not going thru? also, could you clarify, should the notification appear while i'm still offline or should it appear once I enable internet?

@srirambv
Copy link
Contributor

srirambv commented Feb 18, 2019

Verification passed on

Brave 0.60.34 Chromium: 72.0.3626.109 (Official Build) beta(64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Linux

image

  • Verified the error shows up the moment device goes offline at the same time the send tip button is clicked
  • Verified BAT balance didn't go down when the error showed up
  • Verified able to successfully tip when device is online and balance reduced as expected

Verification passed on

Brave 0.60.34 Chromium: 72.0.3626.109 (Official Build) beta (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Windows 10
  • Verified the error shows up the moment device goes offline at the same time the send tip button is clicked
  • Verified BAT balance didn't go down when the error showed up
  • Verified able to successfully tip when device is online and balance reduced as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants