-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change retry and error logic for one-time tips #3052
Comments
I am encountering #2297 when I try the test plan from brave/brave-core#1488. I waited a few minutes with internet off (no notification showed on BAT logo) and when I turned my internet back on, my tip went thru. |
Tried again, this time I got the notification, but when I turned my internet back on, my balance had still gone down by the amount of the tip even though no tip was recorded. Still seems like I'm encountering #2297. |
While testing brave/brave-core#1488 on Windows, I am not getting any notification showed on BAT logo, when internet is OFF. Also when internet back ON I am encountering #2297 |
Tried again with
This time, after disabling internet and waiting about 1-1.5 minutes, no notification showed on BAT logo that tip could not go thru and again, 1 BAT (tip amount) was deducted from my wallet but no Tip displayed on tips list or in summary. After waiting a few more minutes, tip showed up in tips panel and on summary. @NejcZdovc how long should I leave the internet off for to verify that I'll get a message about tip not going thru? also, could you clarify, should the notification appear while i'm still offline or should it appear once I enable internet? |
Verification passed on
Verification passed on
|
If Phase 1 of the contribution process fails on initial attempt, change the logic so that:
-- We do not retry
-- We send a Rewards notification with the message: "Unable to send tip. Please try again later."
If Phase 1 succeeds, we show the tip in the tips panel and reflect it in the Rewards summary.
If there is an error while attempting to complete Phase 2 of the contribution process (in which the votes are being sent) the normal retry logic applies.
The text was updated successfully, but these errors were encountered: