Fixes balance drop on android (uplift to 1.11.x) #5947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
fix-empty-balance-11
branch
from
4dc6007
to
3f644e9
Compare
|
CI failed on test-install, all good |
kjozwiak
approved these changes
Jul 2, 2020
There was a problem hiding this comment.
Uplift into 1.11.x approved after deliberating with @brave/uplift-approvers. QA won't go through the issue on Nightly as we've already tested/checked this before it was uplifted into 1.10.x for Android. @bsclifton went through #5940 (review). We also did a few checks on a call with @NejcZdovc @mandar-brave @evq which were all done on desktop. QA will run through the verification once it lands in 1.11.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #5935
Resolves brave/brave-browser#9992
Resolves brave/brave-browser#10471
Approved, please ensure that before merging:
After you merge: