-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Do not clear url bar text on focus #5978
Conversation
58e3292
to
ec50160
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
ec50160
to
7092567
Compare
Currently on long urls it shows the end part of it. The same behavior the we have when click edit button. @jumde is it ok from security stand point? |
CI failed on audit_deps, not related to this PR |
@samartnik - This is the behavior on iOS: brave/brave-ios#552 (comment) - We should do the same on android. |
7092567
to
436c38c
Compare
Verification passed on OnePlus 6T with Android 10 running 1.13.10 x64 nightly build
Verification passed on Samsung Tab A with Android 9 running 1.13.10 x64 nightly build
|
Resolves brave/brave-browser#10524
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.