Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Do not clear url bar text on focus #5978

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Jun 30, 2020

Resolves brave/brave-browser#10524

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jun 30, 2020
@samartnik samartnik added this to the 1.12.x - Nightly milestone Jun 30, 2020
@samartnik samartnik self-assigned this Jun 30, 2020
@samartnik samartnik force-pushed the android_dont_clear_url_on_focus branch from 58e3292 to ec50160 Compare June 30, 2020 17:33
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik samartnik force-pushed the android_dont_clear_url_on_focus branch from ec50160 to 7092567 Compare July 6, 2020 14:19
@samartnik
Copy link
Contributor Author

samartnik commented Jul 6, 2020

Currently on long urls it shows the end part of it. The same behavior the we have when click edit button. @jumde is it ok from security stand point?
device-2020-07-06-102218

@samartnik samartnik requested a review from jumde July 6, 2020 14:25
@samartnik
Copy link
Contributor Author

CI failed on audit_deps, not related to this PR

@jumde
Copy link
Contributor

jumde commented Jul 8, 2020

@samartnik - This is the behavior on iOS: brave/brave-ios#552 (comment) - We should do the same on android.

@samartnik samartnik force-pushed the android_dont_clear_url_on_focus branch from 7092567 to 436c38c Compare July 8, 2020 20:38
@samartnik samartnik merged commit d9c160d into master Jul 9, 2020
@samartnik samartnik deleted the android_dont_clear_url_on_focus branch July 9, 2020 20:05
brave-builds pushed a commit that referenced this pull request Jul 9, 2020
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.13.10 x64 nightly build


Verification passed on Samsung Tab A with Android 9 running 1.13.10 x64 nightly build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Do not clear url bar text on focus
5 participants