Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Do not clear url bar text on focus (uplift to 1.12.x) #6056

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jul 9, 2020

Uplift of #5978
Resolves brave/brave-browser#10524

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team July 9, 2020 20:15
@brave-builds brave-builds self-assigned this Jul 9, 2020
@brave-builds brave-builds added this to the 1.12.x - Beta milestone Jul 9, 2020
@kjozwiak
Copy link
Member

Looks like build failed on macOS. However, this PR only touches Android related code as per the following:

  • android/brave_java_sources.gni
  • android/java/apk_for_test.flags
  • android/java/org/chromium/chrome/browser/omnibox/suggestions/editurl/BraveEditUrlSuggestionProcessor.java
  • android/javatests/org/chromium/chrome/browser/BytecodeTest.java
  • build/android/bytecode/java/org/brave/bytecode/BraveClassAdapter.java
  • build/android/bytecode/java/org/brave/bytecode/BraveEditUrlSuggestionProcessorClassAdapter.java
  • build/android/bytecode/java_sources.gni
  • patches/chrome-android-java-src-org-chromium-chrome-browser-omnibox-suggestions-AutocompleteMediator.java.patch

Because the PR basically only touches Android code, there's no need to re-run the failed macOS run.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.12.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #5978 (comment).

@kjozwiak kjozwiak merged commit 6433967 into 1.12.x Jul 14, 2020
@kjozwiak kjozwiak deleted the pr5978_android_dont_clear_url_on_focus_1.12.x branch July 14, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants