Add #Labels to imgutil.Image #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekcasey
requested changes
Aug 27, 2020
jabrown85
force-pushed
the
jab/add-labels-to-interface
branch
from
93fc5f8 to
c814736
Compare
We've got [an upcoming feature](buildpacks/lifecycle#390) that requires getting all the lables on an image instead of a specificly named label. Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
jabrown85
force-pushed
the
jab/add-labels-to-interface
branch
from
c814736 to
adc437f
Compare
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
jabrown85
force-pushed
the
jab/add-labels-to-interface
branch
from
ebda826 to
e603eda
Compare
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
jabrown85
force-pushed
the
jab/add-labels-to-interface
branch
from
6269c63 to
d54a998
Compare
ekcasey
approved these changes
Aug 28, 2020
| }) | ||
|
|
||
| when("image NOT exists", func() { | ||
| it("returns an empty map", func() { |
There was a problem hiding this comment.
Not to be too pedantic here but I think it is returning nil not an empty map right?
There was a problem hiding this comment.
Yup. I updated the names, I think we are good.
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
ekcasey
added a commit
to buildpacks/lifecycle
that referenced
this pull request
Dec 10, 2020
Falls back to slower behavior if the daemon does not accept empty layers. This allows the lifecycle to be compatible with podman which requires all layers to be preset during a docker load. buildpacks/imgutil#80 Fixes lifecycle errors in analyze, export, and rebase resulting from a bug in our daemon save logic buildpacks/imgutil#60 Signed-off-by: Emily Casey <ecasey@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've got an upcoming feature that requires getting all the lables on an image instead of a specificly named label.