Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relicensing wasm-tools and this repository's crates #1637

Closed
45 of 47 tasks
alexcrichton opened this issue Jun 26, 2024 · 47 comments · Fixed by #1702
Closed
45 of 47 tasks

Relicensing wasm-tools and this repository's crates #1637

alexcrichton opened this issue Jun 26, 2024 · 47 comments · Fixed by #1702

Comments

@alexcrichton
Copy link
Member

alexcrichton commented Jun 26, 2024 •
edited
Loading

Relicensing wasm-tools

Hello everyone! This issue is here to serve as a checklist for relicensing the wasm-tools repository and all crates that it contains.

  • Before: Apache-2.0 WITH LLVM-exception
  • After: Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT.

In other words this issue is adding two other licensing options to the crate, the Rust standard Apache-2.0 OR MIT option. Everyone who has contributed to this repository is cc'd below with a checkbox tracking their approval status.

If you approve of this license change it's requested you leave a comment along the lines of "I approve this license change" and your checkbox will be filled in by a maintainer.

Why change licenses?

The original choice of Apache-2.0 WITH LLVM-exception for this repository matches the licensing decision of Wasmtime itself and was intended to be compatible with it. Some crates in this repository, however, would like to be integrated into upstream Rust itself. For example the wasmparser and wasm-encoder crates are already part of the Rust compiler. Currently the Rust compiler has an exception which allows these crates despite not having the Rust-standard Apache-2.0 OR MIT license. The goal of this issue is to make integration in the upstream Rust compiler easier by ensuring that the license is fully compatible with Rust's existing license.

Contributors

Contributors to wasm-tools are generated with git shortlog --summary --numbered --email as of 28e96f680752c999f296e5f9d7d31a6be66112f5.

Other contributors

As you can see, we have a long list of contributors to wasm-tools. However, it's not even the entire list! Lots of other people helped us by providing small tweaks to the code, fixing grammar issues in documentation, and similar contributions. While these kinds of contributions are extremely valuable, they aren't covered by copyrights, and thus we don't require sign-off by the authors of these contributions.

We do want to use this opportunity to list everyone who contributed to wasm-tools in whichever way though, so here's the list of people we don't need sign-off from, including links to their contributions:
@jbms
Copy link
Contributor

jbms commented Jun 26, 2024

I approve this license change.

4 similar comments
@fibonacci1729
Copy link
Contributor

I approve this license change.

@MendyBerger
Copy link
Contributor

I approve this license change.

@imikushin
Copy link
Contributor

I approve this license change.

@peterhuene
Copy link
Member

I approve this license change.

@yurydelendik
Copy link
Contributor

I approve this license change

@tschneidereit
Copy link
Member

For external visibility: this kind of license change requires board approval, as documented in section 4 of the Bytecode Alliance's IP policy. The board discussed this back in March and granted the exception.

@bakkot
Copy link
Contributor

bakkot commented Jun 26, 2024

I approve this license change.

4 similar comments
@dhil
Copy link
Contributor

dhil commented Jun 26, 2024

I approve this license change.

@itsrainy
Copy link
Contributor

I approve this license change.

@dicej
Copy link
Collaborator

dicej commented Jun 26, 2024

I approve this license change.

@Robbepop
Copy link
Collaborator

I approve this license change.

@nagisa
Copy link
Contributor

nagisa commented Jun 26, 2024

I approve this license change

1 similar comment
@elliottt
Copy link
Member

I approve this license change

@ydnar
Copy link
Contributor

ydnar commented Jun 26, 2024

I approve this licensing change.

@pchickey
Copy link
Contributor

I approve this license change.

1 similar comment
@juntyr
Copy link
Contributor

juntyr commented Jun 26, 2024

I approve this license change.

@fitzgen
Copy link
Member

fitzgen commented Jun 26, 2024

I approve this license change

@cfallin
Copy link
Member

cfallin commented Jun 26, 2024

I approve this licensing change.

@sunfishcode
Copy link
Member

I approve this license change.

1 similar comment
@bvisness
Copy link
Contributor

I approve this license change.

@azaslavsky
Copy link
Contributor

azaslavsky commented Jun 26, 2024 via email

@YaronWittenstein
Copy link
Contributor

YaronWittenstein commented Jun 26, 2024 via email

@yoshuawuyts
Copy link
Member

I approve this license change.

2 similar comments
@lann
Copy link
Contributor

lann commented Jun 26, 2024

I approve this license change.

@eqrion
Copy link
Collaborator

eqrion commented Jun 26, 2024

I approve this license change.

@abrown
Copy link
Collaborator

abrown commented Jun 26, 2024

I approve this license change

@Liamolucko
Copy link
Contributor

I approve this license change.

2 similar comments
@andylizi
Copy link
Contributor

I approve this license change.

@kateinoigakukun
Copy link
Contributor

I approve this license change.

@maekawatoshiki
Copy link
Contributor

I approve this license change.

3 similar comments
@lars-t-hansen
Copy link
Contributor

I approve this license change.

@jpages
Copy link
Contributor

jpages commented Jun 27, 2024

I approve this license change.

@rylev
Copy link
Contributor

rylev commented Jun 27, 2024

I approve this license change.

@adambratschikaye
Copy link
Contributor

adambratschikaye commented Jun 28, 2024 via email

@takikawa
Copy link
Contributor

takikawa commented Jul 1, 2024

I approve this license change.

1 similar comment
@silesmo
Copy link
Member

silesmo commented Jul 8, 2024

I approve this license change.

@alexcrichton alexcrichton mentioned this issue Jul 8, 2024
Merged
@guybedford
Copy link
Contributor

I approve this license change.

@Mossaka
Copy link
Member

Mossaka commented Jul 8, 2024

I approve this license change

@yowl
Copy link
Contributor

yowl commented Jul 8, 2024

I approve this license change.

@Jacarte
Copy link
Contributor

Jacarte commented Jul 10, 2024

I approve this license change

@alexcrichton
Copy link
Member Author

I reached out to darinmorrison over email and received confirmation from them.

@alexcrichton
Copy link
Member Author

@syrusakbary, I swapped you in for @nlewycky: over email, @nlewycky indicated that you'd need to sign off on behalf of Wasmer as the copyright holder, since these contributions were done while they worked at Wasmer.

@mainrs
Copy link
Contributor

mainrs commented Jul 10, 2024

I approve this license change.

@bholley
Copy link

bholley commented Jul 16, 2024

I approve this change for the work contributed by Mozilla staff (Michael and Julian).

@tschneidereit
Copy link
Member

Alex and I discussed how to handle the remaining contributions for which we don't have sign-off. Instead of waiting and hoping that eventually we might get that sign-off, we assessed the contributions in more detail than before.

The result is that there's only a single commit we still don't have sign-off for where we'd actually need it: the C/C++ bindings contributed by @TheGreatRambler.

This is a meaningful contribution, and we'd very clearly need sign-off to change the license of this code. So instead, we'll keep this code under the current license: it's not something of interest for use by Rust anyway.

The remaining commit we don't have sign-off for were contributed by @nlewycky as a Wasmer employee. A detailed look at these contributions shows that most of them are trivial in the copyright sense (not necessarily in the sense that making these contributions was trivial! Contributions often require careful debugging or investigation work, only to result in small changes that don't clear the creativeness bar copyright requires.) Those parts of the contributions that could even remotely be candidates for copyright happen to not be part of the code base as it is today.

Here's a list of the 11 commits in question, with explanations of why we don't need sign-off for them:
06e5bcc: trivial change
d387165: trivial change
59f1881: trivial change
73dff98: pretty trivial, but also removed in its entirety
8bdcd81: pretty trivial, but also removed in its entirety
96a03c1: pretty trivial, but also removed in its entirety
dfc6f3d: trivial change
32b68b8: trivial change, with anything marginally interesting removed in its entirety
319a2e2: removed in its entirety
cb3bb10: trivial change
ea17086: trivial change

alexcrichton added a commit to alexcrichton/wasm-tools that referenced this issue Jul 29, 2024
@alexcrichton
Relicense this repository
1b1d2dd 
This commit relicenses most crates in this repository under a new
license:

    Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT

where the previous license was:

    Apache-2.0 WITH LLVM-exception

This is done in accordance with bytecodealliance#1637 with signoff from all known
stakeholders with copyrightable contributions. The tl;dr; for why this
change is being made is to better make these crates compatible with the
Rust ecosystem by providing `Apache-2.0 OR MIT` as an option.

Notably this does NOT relicense the C API due to the original
contributor not being able to be reached for the relicensing here. That
part of this repository still retains its original license.

Closes bytecodealliance#1637
@alexcrichton alexcrichton mentioned this issue Jul 29, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 29, 2024
@alexcrichton
Relicense this repository (#1702)
311abc7 
* Relicense this repository

This commit relicenses most crates in this repository under a new
license:

    Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT

where the previous license was:

    Apache-2.0 WITH LLVM-exception

This is done in accordance with #1637 with signoff from all known
stakeholders with copyrightable contributions. The tl;dr; for why this
change is being made is to better make these crates compatible with the
Rust ecosystem by providing `Apache-2.0 OR MIT` as an option.

Notably this does NOT relicense the C API due to the original
contributor not being able to be reached for the relicensing here. That
part of this repository still retains its original license.

Closes #1637

* Remove license symlinks
@TheGreatRambler
Copy link
Contributor

Ah, I approve this license change

alexcrichton added a commit to alexcrichton/wasm-tools that referenced this issue Jul 31, 2024
@alexcrichton
Relicense the C API to match the repository
7170c22 
We have received final sign-off in bytecodealliance#1637 for the C API so this updates
it to have the same license as the rest of the repository to avoid a
one-off special case.
@alexcrichton alexcrichton mentioned this issue Jul 31, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 31, 2024
@alexcrichton
Relicense the C API to match the repository (#1707)
36edf4a 
We have received final sign-off in #1637 for the C API so this updates
it to have the same license as the rest of the repository to avoid a
one-off special case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Relicense this repository alexcrichton/wasm-tools