-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add POST end point to mark calls as no-shows #15690
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
export const noShowHandler = async ({ input }: NoShowOptions) => { | ||
const { bookingUid, attendees } = input; | ||
|
||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved this code to handleMarkShots
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (07/08/24)1 reviewer was added to this PR based on Keith Williams's automation. |
@Udit-takkar why is this being added to v1 and not v2? |
Because the customer that requested this endpoint is using v1 API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be moved to v2. We are no longer adding new functionality to v1. Also, no-show
should not be the route in the URL. It doesn't point to any resource on the server. Instead, we should go through the bookings route.
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Eighty-one Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
* commit '0dd3b2562458522ad002b4ea967e2b10855a4ab6': (130 commits) chore: v4.2.5 (calcom#15735) fix: api v2 unit tests (calcom#15733) fix: event type back button (calcom#15722) fix: remove console.log and tsignore apiv2 (calcom#15732) fix: api-v2 controllers e2e tests (calcom#15724) fix: Text in Embed Code Visibility Fixed (calcom#15711) chore: sort calendar crendentials in event manager (calcom#15448) chore: cache org guard and fix roles guard apiv2 (calcom#15719) Revert "fix: Autodetection of time zone only updated default time zone (calcom#15392)" (calcom#15720) feat: add POST end point to mark calls as no-shows (calcom#15690) chore: add i18n to atoms (calcom#15698) fix: set conferencing apps as default (calcom#15376) fix: disable google-meet in user onboarding if google-calendar is not installed (calcom#15702) fix: Rescheduling email when there is broken calendar integration (calcom#15669) chore: v4.2.4 (calcom#15703) fix: 404s becoming 500s (calcom#15696) fix: delete reserved slot on booker unmount (calcom#15700) chore: add caching apiv2 roles guard (calcom#15694) refactor: handleNewBooking calcom#3 (calcom#15612) fix: incorrect booking seats full error on collective seated event (calcom#15602) ... # Conflicts: # packages/emails/templates/attendee-request-email.ts # packages/emails/templates/attendee-was-requested-to-reschedule-email.ts # packages/emails/templates/organizer-cancelled-email.ts # packages/emails/templates/organizer-location-change-email.ts # packages/emails/templates/organizer-payment-refund-failed-email.ts # packages/emails/templates/organizer-request-email.ts # packages/emails/templates/organizer-request-reminder-email.ts # packages/emails/templates/organizer-requested-to-reschedule-email.ts # packages/emails/templates/organizer-rescheduled-email.ts # packages/emails/templates/organizer-scheduled-email.ts
* feat: add POST end point to mark calls as no-shows * fix: type * feat: add v2 endpoint * wip * chore: type err * chore: add permission * chore: remove packae * chore: remove v1 API endpoint * fix: endpoint * feat: add new version * chore: change route * chore: error msg * fix: message * fix: type err * chore: output * fix: type err * chore: bump libraries to 0.0.17 * chore: add noShowHost --------- Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com> Co-authored-by: Morgan <33722304+ThyMinimalDev@users.noreply.github.com> Co-authored-by: Morgan Vernay <morgan@cal.com>
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Make a request to /api/v2/bookings/{bookingUid}/mark-no-show