Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some minor bugs that caused console errors #3

Merged
merged 1 commit into from
Apr 10, 2021
Merged

Fixed some minor bugs that caused console errors #3

merged 1 commit into from
Apr 10, 2021

Conversation

emrysal
Copy link
Contributor

@emrysal emrysal commented Apr 9, 2021

  • Changed a>li to li>a to accomodate best practises.
  • Link href was complaining the client URL did not match the server URL.
  • Added key to calendar day buttons as react saw it as a list and was throwing missing key errors.
  • Before the selectedDate was selected loading was false, causing availableTimes to be rendered whilst hidden. Then promptly removed when loading started, then re-added after load complete. This also was throwing missing key in the list item, which after fixing, was throwing duplicate key errors as all availableTimes were rendered with {time} set to "invalid date".

@vercel
Copy link

vercel bot commented Apr 9, 2021

@emrysal is attempting to deploy a commit to the calendso Team on Vercel.

To accomplish this, @emrysal needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

@baileypumfleet baileypumfleet merged commit 73ea3ca into calcom:main Apr 10, 2021
KATT added a commit that referenced this pull request Sep 3, 2021
emrysal added a commit that referenced this pull request Sep 29, 2021
3 times is a charm.. can't believe this took 3 tries.
PeerRich pushed a commit that referenced this pull request Sep 29, 2021
3 times is a charm.. can't believe this took 3 tries.
Herbak added a commit to Herbak/calendso that referenced this pull request Oct 14, 2021
emrysal pushed a commit that referenced this pull request Oct 30, 2022
zomars pushed a commit that referenced this pull request May 23, 2023
Tests: add testing for api keys endpoints
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
@alannnc alannnc mentioned this pull request Mar 24, 2024
1 task
Udit-takkar added a commit that referenced this pull request Jun 28, 2024
keithwillcode added a commit that referenced this pull request Jul 8, 2024
* refactor: handleNewBooking #3

* fix: type error

* fix: type err

* fix: type err

* refactor: create booking factor

* chore: refactor availusers

* chore: type err

---------

Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>
Co-authored-by: Keith Williams <keithwillcode@gmail.com>
Udit-takkar added a commit that referenced this pull request Jul 10, 2024
verstratenbram added a commit to verstratenbram/cal.com that referenced this pull request Jul 16, 2024
* commit '0dd3b2562458522ad002b4ea967e2b10855a4ab6': (130 commits)
  chore: v4.2.5 (calcom#15735)
  fix: api v2 unit tests  (calcom#15733)
  fix: event type back button (calcom#15722)
  fix: remove console.log and tsignore apiv2 (calcom#15732)
  fix: api-v2 controllers e2e tests (calcom#15724)
  fix: Text in Embed Code  Visibility Fixed (calcom#15711)
  chore: sort calendar crendentials in event manager (calcom#15448)
  chore: cache org guard and fix roles guard apiv2 (calcom#15719)
  Revert "fix: Autodetection of time zone only updated default time zone (calcom#15392)" (calcom#15720)
  feat: add POST end point to mark calls as no-shows (calcom#15690)
  chore: add i18n to atoms (calcom#15698)
  fix: set conferencing apps as default (calcom#15376)
  fix: disable google-meet in user onboarding if google-calendar is not installed (calcom#15702)
  fix: Rescheduling email when there is broken calendar integration (calcom#15669)
  chore: v4.2.4 (calcom#15703)
  fix: 404s becoming 500s (calcom#15696)
  fix: delete reserved slot on booker unmount (calcom#15700)
  chore: add caching apiv2 roles guard (calcom#15694)
  refactor: handleNewBooking calcom#3 (calcom#15612)
  fix: incorrect booking seats full error on collective seated event (calcom#15602)
  ...

# Conflicts:
#	packages/emails/templates/attendee-request-email.ts
#	packages/emails/templates/attendee-was-requested-to-reschedule-email.ts
#	packages/emails/templates/organizer-cancelled-email.ts
#	packages/emails/templates/organizer-location-change-email.ts
#	packages/emails/templates/organizer-payment-refund-failed-email.ts
#	packages/emails/templates/organizer-request-email.ts
#	packages/emails/templates/organizer-request-reminder-email.ts
#	packages/emails/templates/organizer-requested-to-reschedule-email.ts
#	packages/emails/templates/organizer-rescheduled-email.ts
#	packages/emails/templates/organizer-scheduled-email.ts
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
* refactor: handleNewBooking calcom#3

* fix: type error

* fix: type err

* fix: type err

* refactor: create booking factor

* chore: refactor availusers

* chore: type err

---------

Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>
Co-authored-by: Keith Williams <keithwillcode@gmail.com>
Udit-takkar added a commit that referenced this pull request Sep 12, 2024
Udit-takkar added a commit that referenced this pull request Sep 26, 2024
CarinaWolli pushed a commit that referenced this pull request Oct 2, 2024
* refactor: handleNewBooking #3

* refactor: create booking factor

* refactor: handleNewBooking

* refactor: seats and rescheduleUId

* chore: remove comment

* fix: type err

* chore: add missing statement

* chore: use less params and other improvements

* chore: name

* chore: improvement

* fix: type err

* Typo fix

* chore: fix type err

* refactor: more readable

* refactor: improve code

* fix: conflicts

---------

Co-authored-by: Joe Au-Yeung <j.auyeung419@gmail.com>
Co-authored-by: Joe Au-Yeung <65426560+joeauyeung@users.noreply.github.com>
Co-authored-by: Syed Ali Shahbaz <52925846+alishaz-polymath@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants