Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove console.log and tsignore apiv2 #15732

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

ThyMinimalDev
Copy link
Contributor

What does this PR do?

follow up clean up of #15724

@graphite-app graphite-app bot requested a review from a team July 11, 2024 10:21
@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Jul 11, 2024
Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 10:23am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Jul 11, 2024 10:23am

@graphite-app graphite-app bot requested a review from a team July 11, 2024 10:21
@dosubot dosubot bot added the api area: API, enterprise API, access token, OAuth label Jul 11, 2024
@ThyMinimalDev ThyMinimalDev enabled auto-merge (squash) July 11, 2024 10:23
Copy link

graphite-app bot commented Jul 11, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (07/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (07/11/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Eighty Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 276.79 KB 504.41 KB 144.12% (🟢 -2.12%)
/apps/[slug] 294.35 KB 521.97 KB 149.13% (🟢 -2.12%)
/apps/[slug]/[...pages] 586.55 KB 814.17 KB 232.62% (🟢 -1.74%)
/apps/categories 254.1 KB 481.72 KB 137.63% (🟢 -1.84%)
/apps/categories/[category] 258.91 KB 486.53 KB 139.01% (🟢 -2.11%)
/apps/installation/[[...step]] 466.93 KB 694.55 KB 198.44% (🔴 +85.51%)
/apps/installed/[category] 278.02 KB 505.63 KB 144.47% (🟢 -1.88%)
/auth/saml-idp 12.22 KB 239.84 KB 68.53% (🟢 -20.80%)
/availability 426.18 KB 653.8 KB 186.80% (🟢 -1.78%)
/availability/[schedule] 410.09 KB 637.71 KB 182.20% (🟢 -1.78%)
/bookings/[status] 324.05 KB 551.67 KB 157.62% (🟢 -1.76%)
/enterprise 254.15 KB 481.77 KB 137.65% (🟢 -1.84%)
/event-types 559.21 KB 786.83 KB 224.81% (🟢 -1.76%)
/event-types/[type] 435.76 KB 663.38 KB 189.54% (🟢 -1.65%)
/getting-started/[[...step]] 447.9 KB 675.52 KB 193.01% (🟡 +10.65%)
/insights 474.1 KB 701.72 KB 200.49% (🟢 -1.84%)
/more 253.66 KB 481.28 KB 137.51% (🟢 -1.84%)
/settings/admin 260.1 KB 487.72 KB 139.35% (🟢 -1.83%)
/settings/admin/apps 273.44 KB 501.06 KB 143.16% (🟢 -1.83%)
/settings/admin/apps/[category] 273.42 KB 501.04 KB 143.16% (🟢 -1.83%)
/settings/admin/flags 263.93 KB 491.55 KB 140.44% (🟢 -1.83%)
/settings/admin/impersonation 260.49 KB 488.11 KB 139.46% (🟢 -1.83%)
/settings/admin/lockedSMS 281.58 KB 509.2 KB 145.49% (🟢 -1.80%)
/settings/admin/oAuth 272.21 KB 499.83 KB 142.81% (🟢 -1.82%)
/settings/admin/orgMigrations/_OrgMigrationLayout 249.03 KB 476.65 KB 136.18% (🟢 -1.82%)
/settings/admin/orgMigrations/moveTeamToOrg 298.76 KB 526.38 KB 150.40% (🟢 -1.82%)
/settings/admin/orgMigrations/moveUserToOrg 318.59 KB 546.21 KB 156.06% (🟢 -1.78%)
/settings/admin/orgMigrations/removeTeamFromOrg 298.53 KB 526.15 KB 150.33% (🟢 -1.82%)
/settings/admin/orgMigrations/removeUserFromOrg 298.54 KB 526.16 KB 150.33% (🟢 -1.81%)
/settings/admin/organizations 261.98 KB 489.6 KB 139.89% (🟢 -1.83%)
/settings/admin/organizations/[id]/edit 260.64 KB 488.26 KB 139.50% (🟢 -1.82%)
/settings/admin/users 262.75 KB 490.37 KB 140.11% (🟢 -1.83%)
/settings/admin/users/[id]/edit 391.92 KB 619.54 KB 177.01% (🟢 -1.80%)
/settings/admin/users/add 391.59 KB 619.21 KB 176.92% (🟢 -1.80%)
/settings/billing 260.3 KB 487.92 KB 139.41% (🟢 -1.83%)
/settings/developer/api-keys 264.7 KB 492.32 KB 140.66% (🟢 -1.83%)
/settings/developer/webhooks 264.87 KB 492.49 KB 140.71% (🟢 -1.82%)
/settings/developer/webhooks/[id] 265.85 KB 493.47 KB 140.99% (🟢 -1.81%)
/settings/developer/webhooks/new 265.88 KB 493.5 KB 141.00% (🟢 -1.81%)
/settings/my-account/appearance 313.28 KB 540.89 KB 154.54% (🟢 -1.83%)
/settings/my-account/calendars 271.72 KB 499.34 KB 142.67% (🟢 -1.87%)
/settings/my-account/conferencing 272.61 KB 500.23 KB 142.92% (🟢 -1.86%)
/settings/my-account/general 375.8 KB 603.42 KB 172.41% (🟢 -1.83%)
/settings/my-account/out-of-office 265.33 KB 492.95 KB 140.84% (🟢 -1.82%)
/settings/my-account/profile 408.24 KB 635.86 KB 181.67% (🟢 -1.82%)
/settings/organizations/[id]/about 159.66 KB 387.28 KB 110.65% (🟡 +0.47%)
/settings/organizations/[id]/add-teams 159.65 KB 387.27 KB 110.65% (🟡 +0.47%)
/settings/organizations/admin-api 260.26 KB 487.88 KB 139.39% (🟢 -1.82%)
/settings/organizations/appearance 122.33 KB 349.95 KB 99.98% (🟢 -48.02%)
/settings/organizations/billing 260.34 KB 487.96 KB 139.42% (🟢 -1.83%)
/settings/organizations/dsync 292.96 KB 520.58 KB 148.74% (🟢 -1.83%)
/settings/organizations/general 348.65 KB 576.27 KB 164.65% (🟢 -1.82%)
/settings/organizations/members 399.82 KB 627.44 KB 179.27% (🟢 -1.81%)
/settings/organizations/new 159.66 KB 387.28 KB 110.65% (🟡 +0.47%)
/settings/organizations/privacy 265.85 KB 493.47 KB 140.99% (🟢 -1.83%)
/settings/organizations/profile 413.12 KB 640.73 KB 183.07% (🟡 +1.71%)
/settings/organizations/sso 270.93 KB 498.55 KB 142.44% (🟢 -1.83%)
/settings/organizations/teams/other 261.17 KB 488.79 KB 139.65% (🟢 -1.82%)
/settings/organizations/teams/other/[id]/appearance 273.07 KB 500.69 KB 143.05% (🟢 -1.77%)
/settings/organizations/teams/other/[id]/members 267.76 KB 495.38 KB 141.54% (🟢 -1.83%)
/settings/organizations/teams/other/[id]/profile 471.49 KB 699.1 KB 199.74% (🟢 -1.82%)
/settings/platform 258.76 KB 486.38 KB 138.97% (🟢 -1.84%)
/settings/platform/new 120.67 KB 348.29 KB 99.51% (🟡 +0.51%)
/settings/platform/oauth-clients/[clientId]/edit 257.07 KB 484.69 KB 138.48% (🟢 -1.84%)
/settings/platform/oauth-clients/create 256.21 KB 483.83 KB 138.24% (🟢 -1.84%)
/settings/security/impersonation 265.51 KB 493.13 KB 140.89% (🟢 -1.82%)
/settings/security/password 303.66 KB 531.28 KB 151.79% (🟢 -1.81%)
/settings/security/sso 270.38 KB 498 KB 142.29% (🟢 -1.83%)
/settings/security/two-factor-auth 268.99 KB 496.61 KB 141.89% (🟢 -1.83%)
/settings/teams 259.83 KB 487.45 KB 139.27% (🟢 -1.82%)
/settings/teams/[id]/appearance 273.05 KB 500.67 KB 143.05% (🟢 -1.78%)
/settings/teams/[id]/billing 260.34 KB 487.96 KB 139.42% (🟢 -1.83%)
/settings/teams/[id]/members 377.89 KB 605.51 KB 173.00% (🟢 -1.82%)
/settings/teams/[id]/profile 472.27 KB 699.89 KB 199.97% (🟢 -1.82%)
/settings/teams/new 193 KB 420.62 KB 120.18% (🟢 -1.83%)
/teams 253.89 KB 481.51 KB 137.57% (🟢 -1.84%)
/upgrade 254.01 KB 481.63 KB 137.61% (🟢 -1.84%)
/video/[uid] 291.18 KB 518.8 KB 148.23% (🟢 -0.18%)
/workflows 285.91 KB 513.53 KB 146.72% (🟢 -1.78%)
/workflows/[workflow] 414.08 KB 641.7 KB 183.34% (🟢 -1.59%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@ThyMinimalDev ThyMinimalDev merged commit 844dd7e into main Jul 11, 2024
48 of 67 checks passed
@ThyMinimalDev ThyMinimalDev deleted the fix-api-v2-e2e-tests-2 branch July 11, 2024 10:40
verstratenbram added a commit to verstratenbram/cal.com that referenced this pull request Jul 16, 2024
* commit '0dd3b2562458522ad002b4ea967e2b10855a4ab6': (130 commits)
  chore: v4.2.5 (calcom#15735)
  fix: api v2 unit tests  (calcom#15733)
  fix: event type back button (calcom#15722)
  fix: remove console.log and tsignore apiv2 (calcom#15732)
  fix: api-v2 controllers e2e tests (calcom#15724)
  fix: Text in Embed Code  Visibility Fixed (calcom#15711)
  chore: sort calendar crendentials in event manager (calcom#15448)
  chore: cache org guard and fix roles guard apiv2 (calcom#15719)
  Revert "fix: Autodetection of time zone only updated default time zone (calcom#15392)" (calcom#15720)
  feat: add POST end point to mark calls as no-shows (calcom#15690)
  chore: add i18n to atoms (calcom#15698)
  fix: set conferencing apps as default (calcom#15376)
  fix: disable google-meet in user onboarding if google-calendar is not installed (calcom#15702)
  fix: Rescheduling email when there is broken calendar integration (calcom#15669)
  chore: v4.2.4 (calcom#15703)
  fix: 404s becoming 500s (calcom#15696)
  fix: delete reserved slot on booker unmount (calcom#15700)
  chore: add caching apiv2 roles guard (calcom#15694)
  refactor: handleNewBooking calcom#3 (calcom#15612)
  fix: incorrect booking seats full error on collective seated event (calcom#15602)
  ...

# Conflicts:
#	packages/emails/templates/attendee-request-email.ts
#	packages/emails/templates/attendee-was-requested-to-reschedule-email.ts
#	packages/emails/templates/organizer-cancelled-email.ts
#	packages/emails/templates/organizer-location-change-email.ts
#	packages/emails/templates/organizer-payment-refund-failed-email.ts
#	packages/emails/templates/organizer-request-email.ts
#	packages/emails/templates/organizer-request-reminder-email.ts
#	packages/emails/templates/organizer-requested-to-reschedule-email.ts
#	packages/emails/templates/organizer-rescheduled-email.ts
#	packages/emails/templates/organizer-scheduled-email.ts
p6l-richard pushed a commit to p6l-richard/cal.com-fork that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth core area: core, team members only platform Anything related to our platform plan ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants