Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PackCommand): remove 'parts' argument #341

Merged
merged 2 commits into from
May 9, 2024
Merged

fix(PackCommand): remove 'parts' argument #341

merged 2 commits into from
May 9, 2024

Conversation

mr-cal
Copy link
Contributor

@mr-cal mr-cal commented May 9, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

This ended up being extremely simple after landing #340.

Tested via canonical/snapcraft#4797

@mr-cal mr-cal mentioned this pull request May 9, 2024
Merged
4 tasks
@mr-cal
fix(PackCommand): remove 'parts' argument
90288d3 
Signed-off-by: Callahan Kovacs <callahankovacs@gmail.com>
@mr-cal mr-cal force-pushed the work/drop-parts branch from 26e698d to 90288d3 Compare May 9, 2024 14:26
@mr-cal mr-cal requested a review from tigarmo May 9, 2024 15:25
@mr-cal
chore: de-dupe code
20da7d1 
Signed-off-by: Callahan Kovacs <callahankovacs@gmail.com>
@mr-cal mr-cal requested a review from tigarmo May 9, 2024 17:09
tigarmo
tigarmo approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mr-cal mr-cal merged commit 13230ed into main May 9, 2024
6 checks passed
@mr-cal mr-cal deleted the work/drop-parts branch May 9, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@tigarmo tigarmo tigarmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mr-cal @tigarmo @lengau