refactor: change PackCommand parent #4797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-cal
force-pushed
the
work/pack-directory-fix-2
branch
2 times, most recently
from
1f6b56e to
8e68ca7
Compare
mr-cal
changed the title
3 tasks
mr-cal
force-pushed
the
work/pack-directory-fix-2
branch
from
8e68ca7 to
51d0379
Compare
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
mr-cal
force-pushed
the
work/pack-directory-fix-2
branch
from
51d0379 to
4f3fada
Compare
tigarmo
approved these changes
Jun 7, 2024
lengau
approved these changes
Jun 10, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4797 +/- ##
==========================================
+ Coverage 89.55% 89.68% +0.12%
==========================================
Files 332 335 +3
Lines 22254 22385 +131
==========================================
+ Hits 19930 20075 +145
+ Misses 2324 2310 -14 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)Upstream simplifications (canonical/craft-application#340 and canonical/craft-application#341) allow us to remove some duplicated code.