spread: update flutter test #4015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test had sdk bounds that the latest master would not work with (new DART), while removing the bounds, the pubspec was outdated enough. Moved to the new flutter template post linux desktop beta announcement. The downside is that `<app> --help` now requires X (could be solved with xfvb) but alas, does not print help and exit. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
flutter-test
branch
from
d73ea09 to
ef2f072
Compare
Codecov Report
@@ Coverage Diff @@
## main #4015 +/- ##
=======================================
Coverage 91.61% 91.61%
=======================================
Files 77 77
Lines 5153 5153
=======================================
Hits 4721 4721
Misses 432 432 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mr-cal
approved these changes
Jan 12, 2023
4 tasks
cmatsuoka
pushed a commit
to cmatsuoka/snapcraft
that referenced
this pull request
Feb 8, 2023
The test had sdk bounds that the latest master would not work with (new DART), while removing the bounds, the pubspec was outdated enough. Moved to the new flutter template post linux desktop beta announcement. The downside is that `<app> --help` now requires X (could be solved with xfvb) but alas, does not print help and exit. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test had sdk bounds that the latest master would not work with (new DART), while removing the bounds, the pubspec was outdated enough.
Moved to the new flutter template post linux desktop beta announcement. The downside is that
<app> --helpnow requires X (could be solved with xfvb) but alas, does not print help and exit.Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
make lint?pytest tests/unit?