Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: update craft-parts to 1.15.3 #4030

Conversation

cmatsuoka
Copy link
Contributor

@cmatsuoka cmatsuoka commented Feb 7, 2023

Craft-parts 1.15.3 fixes ignored file patterns when processing local sources.

Signed-off-by: Claudio Matsuoka claudio.matsuoka@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Merging #4030 (99d4b85) into hotfix/7.2 (06ca484) will increase coverage by 0.32%.
The diff coverage is 70.00%.

❗ Current head 99d4b85 differs from pull request most recent head ea509bb. Consider uploading reports for the commit ea509bb to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@              Coverage Diff               @@
##           hotfix/7.2    #4030      +/-   ##
==============================================
+ Coverage       91.04%   91.37%   +0.32%     
==============================================
  Files              56       77      +21     
  Lines            4078     5078    +1000     
==============================================
+ Hits             3713     4640     +927     
- Misses            365      438      +73     
Impacted Files Coverage Δ
snapcraft/linters/library_linter.py 87.23% <70.00%> (-4.66%) ⬇️
snapcraft/projects.py 96.53% <0.00%> (ø)
snapcraft/linters/__init__.py 100.00% <0.00%> (ø)
snapcraft/repo/errors.py 88.88% <0.00%> (ø)
snapcraft/errors.py 91.17% <0.00%> (ø)
snapcraft/repo/apt_ppa.py 90.90% <0.00%> (ø)
snapcraft/__init__.py 72.72% <0.00%> (ø)
snapcraft/ua_manager.py 96.38% <0.00%> (ø)
snapcraft/repo/apt_sources_manager.py 94.73% <0.00%> (ø)
snapcraft/utils.py 84.39% <0.00%> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal
Copy link
Collaborator

mr-cal commented Feb 8, 2023

I think hotfix/7.2 is missing #4015 and #4013, which is causing the 2 core18 spread test failures.

Craft-parts 1.15.3 fixes ignored file patterns when processing
local sources.

Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
@cmatsuoka cmatsuoka force-pushed the 7.2/fix-craft-parts-ignore-patterns branch from 99d4b85 to ea509bb Compare February 8, 2023 16:07
@cmatsuoka cmatsuoka marked this pull request as ready for review February 8, 2023 16:08
@cmatsuoka cmatsuoka enabled auto-merge (squash) February 8, 2023 17:25
@cmatsuoka cmatsuoka merged commit 524866d into canonical:hotfix/7.2 Feb 8, 2023
@cmatsuoka cmatsuoka deleted the 7.2/fix-craft-parts-ignore-patterns branch February 15, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants