Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContainedTabs: provide contained w/ secondary label tab layout helper/component #12843

Closed
3 tasks done
Tracked by #8487
tay1orjones opened this issue Dec 13, 2022 · 0 comments · Fixed by #13366
Closed
3 tasks done
Tracked by #8487

ContainedTabs: provide contained w/ secondary label tab layout helper/component #12843

tay1orjones opened this issue Dec 13, 2022 · 0 comments · Fixed by #13366
Assignees
@francinelucca
Labels
component: tabs package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Milestone
2023 Q1

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Dec 13, 2022 •
edited
Loading

This issue is for providing a layout helper component for contained tabs a secondary label.

Open questions:

  • Can contained tabs with secondary labels be dismissable?
    • If so, it could potentially create a ui shift if the last tab with a secondary label is dismissed causing the entire tab list to be shorter.
  • Can contained tabs with a secondary label be mixed with other contained tabs without secondary labels?
    • A: Yes, but the height remains the same (taller than default tabs)
  • Could/should this just be a prop instead of a layout helper component?

Spec

#12843 (comment)
@tay1orjones tay1orjones mentioned this issue Dec 13, 2022
Closed
@sstrubberg sstrubberg added this to the 2023 Q1 milestone Dec 13, 2022
@sstrubberg sstrubberg added role: dev 🤖 type: enhancement 💡 version: 11 Issues pertaining to Carbon v11 component: tabs proposal: accepted This request has gone through triaging and we are accepting PR's against it. package: @carbon/react @carbon/react labels Dec 13, 2022
@tay1orjones tay1orjones changed the title Tabs: provide contained w/ secondary label tab layout helper/component ContainedTabs: provide contained w/ secondary label tab layout helper/component Dec 13, 2022
@sstrubberg sstrubberg mentioned this issue Mar 15, 2023
Closed
6 tasks
@francinelucca francinelucca mentioned this issue Mar 16, 2023
Merged
@kodiakhq kodiakhq bot closed this as completed in #13366 Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@francinelucca francinelucca

Labels
component: tabs package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Projects
Design System
Archived in project
Roadmap
Archived in project
Milestone
2023 Q1
Development

Successfully merging a pull request may close this issue.

feat(tabs): add support for secondaryLabel francinelucca/carbon
3 participants
@tay1orjones @sstrubberg @francinelucca