Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs: add support for presentational (descriptive) icons in Line/Contained Tabs #12844

Closed
4 tasks done
Tracked by #8487
tay1orjones opened this issue Dec 13, 2022 · 0 comments · Fixed by #13427
Closed
4 tasks done
Tracked by #8487

Tabs: add support for presentational (descriptive) icons in Line/Contained Tabs #12844

tay1orjones opened this issue Dec 13, 2022 · 0 comments · Fixed by #13427
Assignees
@francinelucca
Labels
component: tabs package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Milestone
2023 Q2

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Dec 13, 2022 •
edited
Loading

This issue is for adding support for presentational/descriptive icons in Line/default tabs and ContainedTabs. May be related or implemented alongside #12843

#12844 (comment)
@tay1orjones tay1orjones changed the title Tabs: add support for presentational icons in ContainedTabs Tabs: add support for presentational (descriptive) icons in Line/Contained Tabs Dec 13, 2022
@sstrubberg sstrubberg added this to the 2023 Q1 milestone Dec 13, 2022
@sstrubberg sstrubberg moved this to ⏱ Backlog in Design System Dec 13, 2022
@sstrubberg sstrubberg added type: enhancement 💡 version: 11 Issues pertaining to Carbon v11 component: tabs proposal: accepted This request has gone through triaging and we are accepting PR's against it. labels Dec 13, 2022
@carbon-bot carbon-bot moved this to Triage in Roadmap Dec 13, 2022
@sstrubberg sstrubberg added the package: @carbon/react @carbon/react label Dec 13, 2022
@tay1orjones tay1orjones mentioned this issue Dec 13, 2022
Closed
@sstrubberg sstrubberg moved this from Triage to 2023-Q1 in Roadmap Dec 13, 2022
@sstrubberg sstrubberg mentioned this issue Mar 15, 2023
Closed
6 tasks
@francinelucca francinelucca moved this from ⏱ Backlog to 🏗 In Progress in Design System Mar 29, 2023
@francinelucca francinelucca mentioned this issue Mar 29, 2023
Merged
@francinelucca francinelucca moved this from 🏗 In Progress to 🚦 In Review in Design System Apr 4, 2023
@sstrubberg sstrubberg modified the milestones: 2023 Q1, 2023 Q2 Apr 5, 2023
@kodiakhq kodiakhq bot closed this as completed in #13427 Apr 11, 2023
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Apr 11, 2023
@github-project-automation github-project-automation bot moved this from Next to Completed in Roadmap Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@francinelucca francinelucca

Labels
component: tabs package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Projects
Design System
Archived in project
Roadmap
Archived in project
Milestone
2023 Q2
Development

Successfully merging a pull request may close this issue.

feat(Tabs): add renderIcon prop francinelucca/carbon
3 participants
@tay1orjones @sstrubberg @francinelucca