fix: pass defaultValue in to textarea and text input initial state
#3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit bcf9cbd https://deploy-preview-3015--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit bcf9cbd |
|
Deploy preview for carbon-components-react failed. Built with commit bcf9cbd https://app.netlify.com/sites/carbon-components-react/deploys/5cffee34cb405a00080422e1 |
joshblack
approved these changes
Jun 11, 2019
|
Does this have a test already for defaultValue or should we add one too? |
|
this should cover it https://github.com/carbon-design-system/carbon/blob/master/packages/react/src/components/TextInput/TextInput-test.js#L77-L81 some of these tests look stale though, will refactor them |
lovemecomputer
approved these changes
Jun 11, 2019
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jun 12, 2019
2 tasks
emyarod
added a commit
to emyarod/carbon
that referenced
this pull request
Jun 18, 2019
cal-smith
pushed a commit
to cal-smith/carbon-components
that referenced
this pull request
Jun 21, 2019
…l state" (carbon-design-system#3106) * Revert "fix: pass `defaultValue` in to textarea and text input initial state (carbon-design-system#3015)" This reverts commit d563edf. * Revert "feat: text input and textarea character limit counter (carbon-design-system#2745)" This reverts commit 919ba2e.
cal-smith
pushed a commit
to cal-smith/carbon-components
that referenced
this pull request
Jun 21, 2019
…l state" (carbon-design-system#3106) * Revert "fix: pass `defaultValue` in to textarea and text input initial state (carbon-design-system#3015)" This reverts commit d563edf. * Revert "feat: text input and textarea character limit counter (carbon-design-system#2745)" This reverts commit 919ba2e.
cal-smith
pushed a commit
to cal-smith/carbon-components
that referenced
this pull request
Jun 21, 2019
…l state" (carbon-design-system#3106) * Revert "fix: pass `defaultValue` in to textarea and text input initial state (carbon-design-system#3015)" This reverts commit d563edf. * Revert "feat: text input and textarea character limit counter (carbon-design-system#2745)" This reverts commit 919ba2e.
This was referenced Jul 13, 2021
This was referenced Aug 4, 2021
This was referenced Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3013
The
useStatehook is setting the initial value of the<TextInput>and<TextArea>components as an empty string. This PR passes thedefaultValueprop in as the initial component valueTesting / Reviewing
Ensure that the default value can be set for the two components