Revert "fix: pass defaultValue in to textarea and text input initial state"
#3106
Conversation
This reverts commit 919ba2e.
There was a problem hiding this comment.
LGTM 👍 - Can merge once @shixiedesign agree with this revert. Thanks @emyarod!
|
Deploy preview for the-carbon-components ready! Built with commit bc201a7 https://deploy-preview-3106--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit bc201a7 https://deploy-preview-3106--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit bc201a7 |
|
Deploy preview for the-carbon-components ready! Built with commit e8cab2d https://deploy-preview-3106--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit e8cab2d https://deploy-preview-3106--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit e8cab2d |
There was a problem hiding this comment.
Got a green light from @shixiedesign offline - Thanks @shixiedesign!
dakahn
added
status: visual review 🔍
status: ready to merge 🎉
and removed
status: one more review 👀
status: visual review 🔍
labels
…l state" (carbon-design-system#3106) * Revert "fix: pass `defaultValue` in to textarea and text input initial state (carbon-design-system#3015)" This reverts commit d563edf. * Revert "feat: text input and textarea character limit counter (carbon-design-system#2745)" This reverts commit 919ba2e.
…l state" (carbon-design-system#3106) * Revert "fix: pass `defaultValue` in to textarea and text input initial state (carbon-design-system#3015)" This reverts commit d563edf. * Revert "feat: text input and textarea character limit counter (carbon-design-system#2745)" This reverts commit 919ba2e.
…l state" (carbon-design-system#3106) * Revert "fix: pass `defaultValue` in to textarea and text input initial state (carbon-design-system#3015)" This reverts commit d563edf. * Revert "feat: text input and textarea character limit counter (carbon-design-system#2745)" This reverts commit 919ba2e.
Reverts #3015 also reverts #2745 as it introduced state to the fully controlled
<TextInput>which caused breaking changes