Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set default defaultValue for TextInput and TextArea #3097

Closed
wants to merge 4 commits into from
Closed

fix: set default defaultValue for TextInput and TextArea #3097

wants to merge 4 commits into from

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Jun 18, 2019

ref: #3015

when adding support for defaultValue in #3015, a default value was not assigned if the user did not provide one themselves

Changelog

Changed

  • assign default value to defaultValue prop

Testing / Reviewing

Ensure <TextInput> and <TextArea> function as expected

@emyarod emyarod added this to the v10.4 milestone Jun 18, 2019
@emyarod
Copy link
Member Author

emyarod commented Jun 18, 2019

it looks like some of our tests are failing on master branch

@netlify
Copy link

netlify bot commented Jun 18, 2019

Deploy preview for the-carbon-components ready!

Built with commit 75d9807

https://deploy-preview-3097--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jun 18, 2019

Deploy preview for carbon-elements ready!

Built with commit 75d9807

https://deploy-preview-3097--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jun 18, 2019 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit 2d36545

https://deploy-preview-3097--the-carbon-components.netlify.com

@emyarod emyarod mentioned this pull request Jun 18, 2019
Closed
2 tasks
@netlify
Copy link

netlify bot commented Jun 18, 2019 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 2d36545

https://deploy-preview-3097--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jun 18, 2019

Deploy preview for carbon-components-react failed.

Built with commit 75d9807

https://app.netlify.com/sites/carbon-components-react/deploys/5d08e33ebd97ad00090c4aaf

@netlify
Copy link

netlify bot commented Jun 18, 2019 •
edited
Loading

Deploy preview for carbon-components-react failed.

Built with commit 2d36545

https://app.netlify.com/sites/carbon-components-react/deploys/5d090160621a2000097c80a6

@emyarod emyarod force-pushed the text-input-textarea-defaultvalue branch from b41aa2e to b801106 Compare June 18, 2019 14:50
lovemecomputer
lovemecomputer previously approved these changes Jun 18, 2019
View reviewed changes
@asudoh
Copy link
Contributor

asudoh commented Jun 18, 2019

Note for reviewers; The discussion around what to do with character counter feature for next patch release is going on, as well as one on possibility around "controlled mode" work breaking the change here. Let's wait for those discussion to be settled, hoping it'll be resolved in a day or so.

@emyarod emyarod closed this Jun 18, 2019
@emyarod
Copy link
Member Author

emyarod commented Jun 18, 2019 •
edited
Loading

closing in favor of reverting #3015 and #2745 for now (#3106)

@emyarod emyarod deleted the text-input-textarea-defaultvalue branch June 18, 2019 23:56
@emyarod emyarod mentioned this pull request Mar 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovemecomputer lovemecomputer lovemecomputer left review comments

Assignees
No one assigned
Labels
status: ready for review 👀
Projects
None yet
Milestone
v10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@emyarod @asudoh @lovemecomputer