Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sbt-jupiter-interface to 0.13.x #3988

Closed
wants to merge 1 commit into from

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Nov 19, 2024

Copy of #3501 opened from a separate repo to avoid double testing

Seems like the issue is that the jupiter-test-interface is not configured correctly and is thus missing the test class name as part of the success error reporting

./mill -w 'example.javalib.testing[3-integration-suite].local.test'
[2951]   Test run started (JUnit Jupiter)
[2951]   Test run started (JUnit Jupiter)
[2951]   Test #helloworld() started
[2951]   Test #hello() started
[2951]   Test #helloworld() finished, took 0.014s
[2951]   Test #hello() finished, took 0.013s
[2951]   Test #world() started
[2951]   Test  finished, took 0.025s
[2951]   Test #world() finished, took 0.0s
[2951]   Test  finished, took 0.025s
[2951]   Test  finished, took 0.038s
[2951]   Test run finished: 0 failed, 0 ignored, 1 total, 0.05s
[2951]   Test  finished, took 0.037s
[2951]   Test run finished: 0 failed, 0 ignored, 2 total, 0.049s

@lihaoyi
Copy link
Member Author

lihaoyi commented Nov 19, 2024

@jodersky could you help investigate this one? It might be related to #3983; probably not caused by it, but in the same area of the codebase around the jupiter test framework

@jodersky
Copy link
Member

jodersky commented Nov 19, 2024

I narrowed the change in behavior down to this commit sbt/sbt-jupiter-interface@d9537f9 in sbt-jupyter-interface. Looking into it

@jodersky
Copy link
Member

Even more precisely: sbt/sbt-jupiter-interface@7adbdd0

@jodersky
Copy link
Member

Upstream issue sbt/sbt-jupiter-interface#125 (comment)

@jodersky
Copy link
Member

jodersky commented Nov 20, 2024

FYI, I've submitted a fix uptream awaiting approval

@lihaoyi
Copy link
Member Author

lihaoyi commented Nov 28, 2024

@jodersky looks like sbt-jupiter-interface 0.13.2 is out, so we may be able to make progress on this

@lihaoyi lihaoyi closed this Dec 2, 2024
lihaoyi added a commit that referenced this pull request Dec 3, 2024
Retrying this after fixes were merged upstream

Supersedes #3988

---------

Co-authored-by: Li Haoyi <haoyi.sg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants