Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track prost-types release for Duration error propagation #252

Closed
neacsu opened this issue Jul 4, 2022 · 1 comment · Fixed by #280
Closed

Track prost-types release for Duration error propagation #252

neacsu opened this issue Jul 4, 2022 · 1 comment · Fixed by #280

Comments

@neacsu
Copy link
Contributor

neacsu commented Jul 4, 2022

The current prost-types dependency version doesn't support proper Duration error propagation, which should be fixed when tokio-rs/prost#625 is included in a release.

Once that is done, we can also expose PeriodicAllowance, similarly to how we did in #250 for MsgGrantAllowance, MsgRevokeAllowance, BasicAllowance and
AllowedMsgAllowance
neacsu added a commit to neacsu/cosmos-rust that referenced this issue Jul 4, 2022
@neacsu
Remove commented code and open an issue instead
f63ded6 
Opened issue:

cosmos#252
@neacsu neacsu mentioned this issue Jul 4, 2022
Merged
@tony-iqlusion
Copy link
Member

prost was updated to v0.11 in #277

tony-iqlusion added a commit that referenced this issue Aug 8, 2022
@tony-iqlusion
cosmrs: add additional feegrant domain types
b4318e6 
Adds the domain types originally from #250 (removed in f63ded6) which
were previously blocked on #252
@tony-iqlusion tony-iqlusion mentioned this issue Aug 8, 2022
Merged
@tony-iqlusion tony-iqlusion linked a pull request Aug 8, 2022 that will close this issue
cosmrs: add additional feegrant domain types #280
Merged
tony-iqlusion added a commit that referenced this issue Aug 8, 2022
@tony-iqlusion
cosmrs: add additional feegrant domain types (#280)
b613ce3 
Adds the domain types originally from #250 (removed in f63ded6) which
were previously blocked on #252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cosmrs: add additional feegrant domain types cosmos/cosmos-rust
2 participants
@neacsu @tony-iqlusion