impl Duration::{Display, FromStr} with protobuf format #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR implements to and from string methods for `prost_types::Duration` following the duration format defined by the [Protobuf JSON mapping spec][1]. This is a followup to #615 and re-uses a lot of the same parser helpers. Additionally I did the same error type unification with a new `DurationError` type. This is a breaking change for `prost-types` since public APIs are changed slightly. [1]: https://developers.google.com/protocol-buffers/docs/proto3#json
danburkert
changed the title
LucioFranco
approved these changes
Apr 18, 2022
neacsu
added a commit
to neacsu/cosmos-rust
that referenced
this pull request
Jun 29, 2022
Expose MsgGrantAllowance, MsgRevokeAllowance, BasicAllowance and AllowedMsgAllowance from cosmrs. The current prost-types dependency version doesn't support proper Duration error propagation, which should be fixed when tokio-rs/prost#625 is included in a release. Until then, I only included the code for PeriodicAllowance as commented.
This was referenced Jun 29, 2022
neacsu
added a commit
to neacsu/cosmos-rust
that referenced
this pull request
Jul 4, 2022
Expose MsgGrantAllowance, MsgRevokeAllowance, BasicAllowance and AllowedMsgAllowance from cosmrs. The current prost-types dependency version doesn't support proper Duration error propagation, which should be fixed when tokio-rs/prost#625 is included in a release. Until then, I only included the code for PeriodicAllowance as commented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements to and from string methods for
prost_types::Durationfollowing the duration format defined by theProtobuf JSON mapping spec.
This is a followup to #615 and re-uses a lot of the same parser helpers.
Additionally I did the same error type unification with a new
DurationErrortype. This is a breaking change forprost-typessincepublic APIs are changed slightly.