Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feegrant module support #250

Merged
merged 2 commits into from
Jul 23, 2022

Conversation

neacsu
Copy link
Contributor

@neacsu neacsu commented Jun 29, 2022

Expose MsgGrantAllowance, MsgRevokeAllowance, BasicAllowance and
AllowedMsgAllowance from cosmrs.

The current prost-types dependency version doesn't support proper
Duration error propagation, which should be fixed when
tokio-rs/prost#625 is included in a release.
Until then, I only included the code for PeriodicAllowance as commented.
Created tracking issue for when a new prost-types release happens: #252

@neacsu neacsu mentioned this pull request Jun 29, 2022
1 task
Copy link
Member

@tony-iqlusion tony-iqlusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit about commented-out code, otherwise this looks good

Expose MsgGrantAllowance, MsgRevokeAllowance, BasicAllowance and
AllowedMsgAllowance from cosmrs.

The current prost-types dependency version doesn't support proper
Duration error propagation, which should be fixed when
tokio-rs/prost#625 is included in a release.
Until then, I only included the code for PeriodicAllowance as commented.
@neacsu neacsu force-pushed the neacsu/feegrant_support branch from 484f3b8 to f63ded6 Compare July 4, 2022 08:27
@neacsu neacsu requested a review from tony-iqlusion July 4, 2022 08:27
@tony-iqlusion tony-iqlusion merged commit 4c4e3ea into cosmos:main Jul 23, 2022
@tony-iqlusion tony-iqlusion mentioned this pull request Jul 26, 2022
tony-iqlusion added a commit that referenced this pull request Aug 8, 2022
Adds the domain types originally from #250 (removed in f63ded6) which
were previously blocked on #252
tony-iqlusion added a commit that referenced this pull request Aug 8, 2022
Adds the domain types originally from #250 (removed in f63ded6) which
were previously blocked on #252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants