Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custom-targets): fix bug in transactions, handle more failure cases, include more helpful text with failure responses #488

Merged
merged 3 commits into from
May 31, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented May 31, 2024

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #487
See also cryostatio/cryostat-web#1262

Description of the change:

  • fixes transaction handling bug (see fix(db): correct use of Transactional annotation #415)
  • include better/more informative/more understandable error messages in responses
  • check for duplicate URL or duplicate target (same JVM ID) cases in connection test, not only at creation time

How to manually test:

  1. Check out and build PR
  2. ./smoktest.bash -Otr
  3. Go to Custom Target creation form
  4. Try to create various custom targets like cryostat3:9091, localhost:0, sample-app-1:9093, jfr-datasource:11223, reports:11224

…es, include more helpful text with failure responses
aali309
aali309 previously approved these changes May 31, 2024
@aali309 aali309 self-requested a review May 31, 2024 18:01
@aali309
Copy link
Contributor

aali309 commented May 31, 2024

/build_test

Copy link

Workflow started at 5/31/2024, 2:16:20 PM. View Actions Run.

Copy link

No GraphQL schema changes detected.

Copy link

No OpenAPI schema changes detected.

Copy link

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/9322544977

aali309
aali309 previously approved these changes May 31, 2024
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andrewazores andrewazores merged commit c87185a into cryostatio:main May 31, 2024
7 checks passed
@andrewazores andrewazores deleted the custom-target-tx branch May 31, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Custom Target creation failures no longer include relevant error information
2 participants