Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

features/docs/getting_started.feature:7 fails on Ruby 2.4. #1071

Closed
voxik opened this issue Jan 20, 2017 · 3 comments · Fixed by #1080
Closed

features/docs/getting_started.feature:7 fails on Ruby 2.4. #1071

voxik opened this issue Jan 20, 2017 · 3 comments · Fixed by #1080

Comments

@voxik
Copy link
Contributor

voxik commented Jan 20, 2017

Summary

The test case features/docs/getting_started.feature:7 fails on Ruby 2.4:

Expected Behavior

The test should pass.

Current Behavior

expected "No such file or directory @ rb_sysopen - features. You can use `cucumber --init` to get started.\n" to include "No such file or directory - features. You can use `cucumber --init` to get started."
Diff:
@@ -1,2 +1,2 @@
-No such file or directory - features. You can use `cucumber --init` to get started.
+No such file or directory @ rb_sysopen - features. You can use `cucumber --init` to get started.
 (RSpec::Expectations::ExpectationNotMetError)
features/docs/getting_started.feature:10:in `Then it should fail with:'

Failing Scenarios:
cucumber features/docs/getting_started.feature:7 # Scenario: Run Cucumber in an empty directory

Possible Solution

This obviously fails due to https://github.com/cucumber/cucumber-ruby/blob/master/lib/cucumber/runtime.rb#L34 . Isn't it about the time to drop the https://github.com/cucumber/cucumber-ruby/blob/master/lib/cucumber/runtime.rb#L15 ? All currently supported Ruby prints this and I don't think it is going to change soon.

@voxik
Copy link
Contributor Author

voxik commented Jan 20, 2017

Other option is to include it unconditionally ....

@mattwynne
Copy link
Member

Thanks for looking into this @voxik!

I'd definitely prefer if we can avoid showing the @ rb_sysopen noise to our users.

I think it would be nicer to stop subclassing the FileException and just raise our own error with our own message, and get rid of all of that cruft. Would you like to send a PR for that?

junaruga added a commit to junaruga/cucumber-ruby that referenced this issue Feb 8, 2017
@junaruga junaruga mentioned this issue Feb 8, 2017
5 tasks
junaruga added a commit to junaruga/cucumber-ruby that referenced this issue Feb 8, 2017
junaruga added a commit to junaruga/cucumber-ruby that referenced this issue Feb 14, 2017
junaruga added a commit to junaruga/cucumber-ruby that referenced this issue Feb 14, 2017
junaruga added a commit to junaruga/cucumber-ruby that referenced this issue Feb 15, 2017
junaruga added a commit to junaruga/cucumber-ruby that referenced this issue Feb 18, 2017
junaruga added a commit to junaruga/cucumber-ruby that referenced this issue Feb 18, 2017
junaruga added a commit to junaruga/cucumber-ruby that referenced this issue Feb 23, 2017
nodo pushed a commit that referenced this issue Feb 26, 2017
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants