-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests for Ruby 2.4.0 #1077
Fix tests for Ruby 2.4.0 #1077
Conversation
ab8224d
to
f40781a
Compare
Finally we passed the tests for Ruby 2.4.0. |
before_script: | ||
# Patch for Ruby 2.4.0 compatibility. | ||
- ./scripts/patch_simplecov_0_12_0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to upgrade to simplecov 0.13
. This issue should be fixed: https://github.com/colszowka/simplecov/blob/0.13.0/CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nodo yes of course using simplecov 0.13
is better if we can use it on Travis.
But right now we can not use it on Travis, as far as I know.
Because we are using latest version coveralls 0.8.19
in our cucumber-ruby
.
And it needs simplecov
0.12.x.
Actually I tried to do something to use simplecov 0.13
at first on Traivs. but I failed to use it.
See Gemfile.lock
file after bundle install --path vendor/bundle
in your local environment.
Gemfile.lock
...
coveralls (0.8.19)
json (>= 1.8, < 3)
simplecov (~> 0.12.0)
...
About this situation, I have reported to coveralls
upstream github.
So, they may change their dependency to use simplecov 0.13
.
So the script ./scripts/patch_simplecov_0_12_0
is temporary one to pass the test for Ruby 2.4.0.
After they may update coveralls
, we can remove this script.
I could not see the simplecov
warnings in my local environment.
I do not know why..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a reference, running ./scripts/patch_simplecov_0_12_0
is same with patching simplecov-ruby/simplecov@050eb68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also https://github.com/lemurheavy/coveralls-ruby/blob/v0.8.19/coveralls-ruby.gemspec#L23
If coveralls
new version with simplecov
0.13 will be released, we do not need this patch for simplecov
.
It's also good to watch coveralls
project for that.
lib/cucumber/runtime.rb
Outdated
def initialize(path) | ||
super('No such file or directory - features') | ||
@path = path | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure why this change is needed. Please, can you tell which test is failing for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nodo because of fixing this issue #1071 (comment) (Reason of the issue is https://bugs.ruby-lang.org/issues/9285)
There are 2 possible ways to fix this issue. And @mattwynne prefer "2".
- Adding
Cucumber::RUBY_2_4
in above logic (FeatureFolderNotFoundException class). - Not extending
FileException
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f40781a
to
aa655c2
Compare
The script should be removed after simplecov-0.13.0 is available for cucumber.
ec5e3ec
to
1ec207a
Compare
I think my solution for failure tests by simplecov warnings, was not good. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes tests for Ruby 2.4.0.
This fixes #1071
I referred #1071 (comment) about how to fix
Details
Motivation and Context
Want to pass tests on Ruby 2.4.0.
How Has This Been Tested?
Same way with #1069 (comment)
Screenshots (if appropriate):
Types of changes
Bug fix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
I changed from
FeatureFolderNotFoundException(e, path)
toFeatureFolderNotFoundException(path)
Checklist: