Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.7.2 take 1 #2717

Merged
merged 16 commits into from
Jul 26, 2018
Merged

7.7.2 take 1 #2717

merged 16 commits into from
Jul 26, 2018

Conversation

matthewrmshin
Copy link
Contributor

@matthewrmshin matthewrmshin commented Jul 6, 2018 •
edited
Loading

@matthewrmshin matthewrmshin added this to the next maintenance release milestone Jul 6, 2018
@matthewrmshin matthewrmshin self-assigned this Jul 6, 2018
@oliver-sanders
Copy link
Member

We may as well hold this until we've slotted in (or bumped) the 5 outstanding next maintenance issues.

matthewrmshin and others added 9 commits July 18, 2018 15:00
@matthewrmshin
Fix remote always in UTC
a8bb1da
@matthewrmshin
Fix test comment
ce60acd
@matthewrmshin
Fix restart-reload release runahead bug
12d0b5a 
For a suite with no final cycle point and tasks in the runahead point
(e.g. due to max active cycle points), a restart followed by a reload
would bring down the suite because the stop point was loaded from the
database as a string 'None' instead of a proper None.

This fixes the issue.
@matthewrmshin
Test cylc#2722 fix
5dc661c
@oliver-sanders @matthewrmshin
fix exclusions
9a56b69
@oliver-sanders @matthewrmshin
improve poll logging
c22bab7
@oliver-sanders @matthewrmshin
pep8 and grep fix
4665e35
@oliver-sanders @matthewrmshin
codacy_happiness += 1
ec74c83
@kinow @matthewrmshin
Avoid creating an unnecessary SuiteProcPool
8d9579a
@matthewrmshin
Copy link
Contributor Author

This should be the final version. I'll kick off some tests in my normal work environment as well.

@oliver-sanders
Copy link
Member

This has all Next Maintenance PRs except #2721, if we want to bump it to next release that's fine with me, just change the milestone.

oliver-sanders and others added 2 commits July 25, 2018 16:41
@oliver-sanders @matthewrmshin
better test for git working copy
23cee60
@matthewrmshin
Remote tests tidy
0d55a8a 
Purge remote suite directory.
Fix job-kill 04 PBS out of memory issue.
@matthewrmshin
Copy link
Contributor Author

#2721 and #2736 added. The is the final version after the previous final version.

@matthewrmshin
Copy link
Contributor Author

All good in my environment.

@hjoliver
Copy link
Member

I can make the release as soon as @oliver-sanders approves this.

oliver-sanders
oliver-sanders approved these changes Jul 26, 2018
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this.

@hjoliver hjoliver merged commit ada4a23 into cylc:7.7.x Jul 26, 2018
@matthewrmshin matthewrmshin deleted the 7.7.x branch July 26, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@matthewrmshin matthewrmshin

Labels
None yet
Projects
None yet
Milestone
cylc-7.7.2
Development

Successfully merging this pull request may close these issues.
5 participants
@matthewrmshin @oliver-sanders @hjoliver @kinow @dpmatthews