Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support loading config files for projects with type module, without esbuild #21574

Merged
merged 24 commits into from
May 31, 2022
Merged

fix: support loading config files for projects with type module, without esbuild #21574

Changes from 2 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
53d500c
fix: support loading config files for projects with type module, with…
JessicaSachs May 19, 2022
a18bb9e
Update packages/server/lib/plugins/child/run_require_async_child.js
JessicaSachs May 19, 2022
5733d7c
Update packages/server/lib/plugins/child/run_require_async_child.js
JessicaSachs May 19, 2022
2d4399e
Merge branch '10.0-release' into fix/module-projects-without-esbuild
JessicaSachs May 20, 2022
3d06929
Merge branch '10.0-release' into fix/module-projects-without-esbuild
JessicaSachs May 23, 2022
63b428a
fix: adding process.cwd() to require.resolve paths so that system-tes…
JessicaSachs May 23, 2022
d007fd6
Merge branch '10.0-release' into fix/module-projects-without-esbuild
tgriesser May 24, 2022
a7c71dd
Merge branch 'develop' of github.com:cypress-io/cypress into fix/modu…
JessicaSachs May 26, 2022
7c5350a
fix: missing esbuild from test
JessicaSachs May 26, 2022
d5ba8cc
Merge branch 'fix/module-projects-without-esbuild' of github.com:cypr…
JessicaSachs May 26, 2022
89d2077
Merge branch 'develop' into fix/module-projects-without-esbuild
JessicaSachs May 27, 2022
7ed4ba7
Merge branch 'develop' into fix/module-projects-without-esbuild
JessicaSachs May 27, 2022
e77a696
Merge branch 'develop' into fix/module-projects-without-esbuild
JessicaSachs May 27, 2022
582e2c4
test
JessicaSachs May 27, 2022
69e530a
Merge remote-tracking branch 'origin' into fix/module-projects-withou…
JessicaSachs May 27, 2022
d35c9ed
Merge branch 'fix/module-projects-without-esbuild' of github.com:cypr…
JessicaSachs May 27, 2022
26e1378
build plz
flotwig May 27, 2022
d437afd
Merge branch 'develop' into fix/module-projects-without-esbuild
tgriesser May 31, 2022
facb21c
Merge branch 'develop' into fix/module-projects-without-esbuild
mjhenkes May 31, 2022
c952a29
Update test case to capture failure
tgriesser May 31, 2022
d2d8d15
Merge branch 'develop' into fix/module-projects-without-esbuild
mjhenkes May 31, 2022
310a44e
empty message for fresh CI
tgriesser May 31, 2022
08a87d8
fix flaky test
tgriesser May 31, 2022
71cbb69
See if esbuild helps with migration-e2e-module on windows
tgriesser May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/server/lib/plugins/child/run_require_async_child.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ function run (ipc, file, projectRoot) {

return (await bundleRequire({ filepath: file })).mod
} catch (err) {
if (err.stack.includes(`Cannot find package 'esbuild'`)) {
if (err.stack.includes(`Cannot find package 'esbuild'`) || err.stack.includes(`Cannot find module 'esbuild'`)) {
JessicaSachs marked this conversation as resolved.
Show resolved Hide resolved
debug(`User doesn't have esbuild. Going to use native node imports.`)

// We cannot replace the initial `require` with `await import` because
Expand Down