New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EnumFieldRenderer. #3716

Merged

kallentu merged 1 commit into main from enum-renderer

Mar 12, 2024

Member

kallentu commented Mar 12, 2024

Inlining EnumFieldRenderer.

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.


          Remove EnumFieldRenderer.

16e3518

kallentu requested a review from srawlins

March 12, 2024 19:40

srawlins approved these changes

View reviewed changes

Member

srawlins left a comment

Nice!

kallentu merged commit e8ee798 into main

11 checks passed

kallentu deleted the enum-renderer branch

March 12, 2024 20:45

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request


          [deps] rev dartdoc, ecosystem, http, test, web

9bcfb21

Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/89a3b4a..b001a15):
  b001a150  2024-03-13  Kallen Tu  Remove ModelElementRenderer. (dart-lang/dartdoc#3717)
  e8ee7983  2024-03-12  Kallen Tu  Remove EnumFieldRenderer. (dart-lang/dartdoc#3716)

ecosystem (https://github.com/dart-lang/ecosystem/compare/49a3cbb..5a900ca):
  5a900ca  2024-03-12  Moritz  Only check text files for "do not submit" string (dart-lang/ecosystem#243)

http (https://github.com/dart-lang/http/compare/8da6e0e..5dfea72):
  5dfea72  2024-03-11  Derek Xu  Add getters to classes (dart-lang/http#1151)

test (https://github.com/dart-lang/test/compare/ba64bbb..6a4e75a):
  6a4e75a6  2024-03-13  Graciliano Monteiro Passos  Update the documentation for the `skip` parameter in the `test` (dart-lang/test#2102)

web (https://github.com/dart-lang/web/compare/51e594b..2f13cd5):
  2f13cd5  2024-03-12  Devon Carew  fix unresolved dartdoc links (dart-lang/web#200)
  686827a  2024-03-12  Srujan Gaddam  Remove reference to static interop and point to dart.dev page for JS interop (dart-lang/web#206)
  9b7e29d  2024-03-12  Devon Carew  Add a 'sourced from mdn docs' line to the MDN sourced dartdoc (dart-lang/web#198)

Change-Id: I99e68e24efda6f0f95ac3b0a51a2c76e0b0971f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357661
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet