Update the documentation for the skip parameter in the test
#2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmpassos
changed the title
skip parameter in the test funct…skip parameter in the test
jakemac53
reviewed
Sep 26, 2023
|
This PR needs to be rebased |
Resolved |
Add a unit test for the described behavior. Update an integration test to demonstrate that a suite level `@Skip()` annotation cannot be overridden, it will always show as _one_ test skipped. Remove all but the first `[]` link for each reference in the paragraph. Surround the other references with backticks for code blocks.
|
Hmm, I pushed a commit which added tests, but the PR didn't update like it should. I'm not sure if there is some way to poke the PR to get it to pick up the new commit? |
|
I think that the PR is OK now. It's showing the changed test files. |
|
Why use |
Unintentional typos, I ran a shortcut to change the surrounding characters but typed |
|
@jakemac53 - can you take another look with the added tests? |
jakemac53
approved these changes
Mar 13, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Mar 14, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/89a3b4a..b001a15): b001a150 2024-03-13 Kallen Tu Remove ModelElementRenderer. (dart-lang/dartdoc#3717) e8ee7983 2024-03-12 Kallen Tu Remove EnumFieldRenderer. (dart-lang/dartdoc#3716) ecosystem (https://github.com/dart-lang/ecosystem/compare/49a3cbb..5a900ca): 5a900ca 2024-03-12 Moritz Only check text files for "do not submit" string (dart-lang/ecosystem#243) http (https://github.com/dart-lang/http/compare/8da6e0e..5dfea72): 5dfea72 2024-03-11 Derek Xu Add getters to classes (dart-lang/http#1151) test (https://github.com/dart-lang/test/compare/ba64bbb..6a4e75a): 6a4e75a6 2024-03-13 Graciliano Monteiro Passos Update the documentation for the `skip` parameter in the `test` (dart-lang/test#2102) web (https://github.com/dart-lang/web/compare/51e594b..2f13cd5): 2f13cd5 2024-03-12 Devon Carew fix unresolved dartdoc links (dart-lang/web#200) 686827a 2024-03-12 Srujan Gaddam Remove reference to static interop and point to dart.dev page for JS interop (dart-lang/web#206) 9b7e29d 2024-03-12 Devon Carew Add a 'sourced from mdn docs' line to the MDN sourced dartdoc (dart-lang/web#198) Change-Id: I99e68e24efda6f0f95ac3b0a51a2c76e0b0971f3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357661 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not documented that
test(skip:)will overwrite the behavior of thegroup(skip:)