Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check text files for "do not submit" string #243

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Mar 11, 2024

To avoid failures such as https://github.com/dart-lang/native/actions/runs/8236607137/job/22523430279?pr=987.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@mosuem mosuem requested a review from devoncarew March 11, 2024 17:43
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:firehose 0.8.0 ready to publish firehose-v0.8.0
package:dart_flutter_team_lints 2.1.1 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

github-actions bot commented Mar 11, 2024

PR Health

Breaking changes ✔️

Details
Package Change Current Version New Version Needed Version Looking good?
firehose None 0.7.0 0.8.0 0.7.0 ✔️

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

Details
File Coverage
pkgs/firehose/lib/src/health/health.dart 💚 93 %

This check for test coverage is informational (issues shown here will not fail the PR).

License Headers ✔️

Details
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️

Details
Package Version Status
package:firehose 0.8.0 ready to publish
package:dart_flutter_team_lints 2.1.1 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@mosuem mosuem merged commit 5a900ca into main Mar 12, 2024
23 checks passed
@mosuem mosuem deleted the onlyCheckTextFilesForDNS branch March 12, 2024 12:01
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Mar 14, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/89a3b4a..b001a15):
  b001a150  2024-03-13  Kallen Tu  Remove ModelElementRenderer. (dart-lang/dartdoc#3717)
  e8ee7983  2024-03-12  Kallen Tu  Remove EnumFieldRenderer. (dart-lang/dartdoc#3716)

ecosystem (https://github.com/dart-lang/ecosystem/compare/49a3cbb..5a900ca):
  5a900ca  2024-03-12  Moritz  Only check text files for "do not submit" string (dart-lang/ecosystem#243)

http (https://github.com/dart-lang/http/compare/8da6e0e..5dfea72):
  5dfea72  2024-03-11  Derek Xu  Add getters to classes (dart-lang/http#1151)

test (https://github.com/dart-lang/test/compare/ba64bbb..6a4e75a):
  6a4e75a6  2024-03-13  Graciliano Monteiro Passos  Update the documentation for the `skip` parameter in the `test` (dart-lang/test#2102)

web (https://github.com/dart-lang/web/compare/51e594b..2f13cd5):
  2f13cd5  2024-03-12  Devon Carew  fix unresolved dartdoc links (dart-lang/web#200)
  686827a  2024-03-12  Srujan Gaddam  Remove reference to static interop and point to dart.dev page for JS interop (dart-lang/web#206)
  9b7e29d  2024-03-12  Devon Carew  Add a 'sourced from mdn docs' line to the MDN sourced dartdoc (dart-lang/web#198)

Change-Id: I99e68e24efda6f0f95ac3b0a51a2c76e0b0971f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/357661
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants