Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create strategy around updating and maintaining protoc version #1685

Open
devinrsmith opened this issue Dec 13, 2021 · 0 comments
Open

Create strategy around updating and maintaining protoc version #1685

devinrsmith opened this issue Dec 13, 2021 · 0 comments

Comments

@devinrsmith
Copy link
Member

We've separated out some protoc generation into https://github.com/deephaven/deephaven-base-images, protoc-base. It specifies a protoc version, but so does deephaven-core. It would be good to ensure that they are in-sync. Either:

  • Implicitly inherit the same version that protoc-base uses (this may be tough given the gradle configuration lifecycle)
  • Check at build time that the versions are the same
    • May be wise to set environment variable or label on base image

Furthermore, we should likely try to keep up to date with more recent versions of protoc.

@devinrsmith devinrsmith added this to the Dec 2021 milestone Dec 13, 2021
@devinrsmith devinrsmith self-assigned this Dec 13, 2021
@pete-petey pete-petey modified the milestones: Dec 2021, Jan 2022 Dec 29, 2021
@pete-petey pete-petey modified the milestones: Jan 2022, May 2022 Apr 16, 2022
@pete-petey pete-petey modified the milestones: May 2022, Sept 2022 Aug 16, 2022
@pete-petey pete-petey modified the milestones: Sept 2022, Apr 2023 Apr 19, 2023
@pete-petey pete-petey modified the milestones: Apr 2023, August 2023 Jul 31, 2023
mofojed pushed a commit that referenced this issue Jan 26, 2024
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.60.0

# [0.60.0](deephaven/web-client-ui@v0.59.0...v0.60.0) (2024-01-26)


### Bug Fixes

* Fix useDeferredApi export ([#1742](deephaven/web-client-ui#1742)) ([af5f5f4](deephaven/web-client-ui@af5f5f4))
* Handle undefined DashboardData props ([#1726](deephaven/web-client-ui#1726)) ([45fa929](deephaven/web-client-ui@45fa929586c0b13a738eceaa064b261eecbd8308))(https://github.com/deephaven/web-client-ui/issues/1684) [#1685](deephaven/web-client-ui#1685)
* hcm caret shouldn't be allowed to shrink ([#1733](deephaven/web-client-ui#1733)) ([6547814](deephaven/web-client-ui@6547814))
* keep manually entered value in GoToRow when changing to same column type ([#1743](deephaven/web-client-ui#1743)) ([689a1e2](deephaven/web-client-ui@689a1e2))
* loading spinner finishes before all series load ([#1729](deephaven/web-client-ui#1729)) ([e79297b](deephaven/web-client-ui@e79297b))


### Features

* Add pluginDataMap to redux, add useDashboardPluginData hook ([#1737](deephaven/web-client-ui#1737)) ([e1b4562](deephaven/web-client-ui@e1b4562))
* added shortcut for copying version info and added browser/os to info ([#1739](deephaven/web-client-ui#1739)) ([3312133](deephaven/web-client-ui@3312133))
* Adds icons dhUnderline and dhStrikethrough ([#1732](deephaven/web-client-ui#1732)) ([c6a099d](deephaven/web-client-ui@c6a099d))
* adjust display of  theme palette in styleguide ([#1745](deephaven/web-client-ui#1745)) ([0ab0c93](deephaven/web-client-ui@0ab0c93))
* Create UI to Display Partitioned Tables ([#1663](deephaven/web-client-ui#1663)) ([db219ca](deephaven/web-client-ui@db219ca))
* Default Plotly map colors ([#1721](deephaven/web-client-ui#1721)) ([e8b9f12](deephaven/web-client-ui@e8b9f12))
* double-clicking grid rows should select the row rather than toggle selection twice ([#1740](deephaven/web-client-ui#1740)) ([f892e97](deephaven/web-client-ui@f892e97))
* Multiple dashboards ([#1714](deephaven/web-client-ui#1714)) ([32dde3c](deephaven/web-client-ui@32dde3c))

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants